On Wed, Nov 20, 2019 at 6:24 PM Anatoly Burakov <anatoly.bura...@intel.com> wrote: > > Since the library versioning for both stable and experimental ABI's is > now managed globally, the LIBABIVER and version variables no longer > serve any useful purpose, and can be removed. > > The replacement in Makefiles was done using the following regex: > > ^(#.*\n)?LIBABIVER\s*:=\s*\d+\n(\s*\n)? > > (LIBABIVER := numbers, optionally preceded by a comment and optionally > succeeded by an empty line) > > The replacement for meson files was done using the following regex: > > ^(#.*\n)?version\s*=\s*\d+\n(\s*\n)? > > (version = numbers, optionally preceded by a comment and optionally > succeeded by an empty line) > > Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
Caught two leftovers: [dmarchan@dmarchan dpdk.org]$ git ls-tree -r HEAD --name-only |grep Makefile |xargs grep '\<LIBABIVER\>[[:space:]]*:*=' drivers/common/qat/Makefile: LIBABIVER := 1 [dmarchan@dmarchan dpdk.org]$ git ls-tree -r HEAD --name-only |grep meson.build |xargs grep '\<version\>[[:space:]]*=' lib/librte_eal/meson.build:version = 12 # the version of the EAL API I will fix when applying and add a little note about them in the commitlog. -- David Marchand