Hi,

> -----Original Message-----
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Thursday, November 21, 2019 5:23
> To: Xu, Rosen <rosen...@intel.com>
> Cc: dev@dpdk.org; Zhang, Tianfei <tianfei.zh...@intel.com>; Pei, Andy
> <andy....@intel.com>; Ye, Xiaolong <xiaolong...@intel.com>; Yigit, Ferruh
> <ferruh.yi...@intel.com>; david.march...@redhat.com
> Subject: Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler
> 
> Rosen (and most of your colleagues),
> Please use --in-reply-to when sending a new version.
> All versions must be a reply to the very first cover letter.

Got, thanks your reminder.

> 14/11/2019 10:02, Rosen Xu:
> > +   IFPGA_RAWDEV_PMD_INFO("seu emr low: 0x%lx\n", val);
> 
> Using %lx is usually wrong.
> val is 64-bit.
> On 32-bit machines (like some Intel ones), it does not compile.
> I had to fix it while pulling next-net.
> 
> The same issue was in "raw/ifpga/base: clean fme errors".
> 
> Please check 32-bit compilation.
> 
> Note: we should have such check in the CI.
> 

Reply via email to