[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

rjmccall added a comment. I thought you were saying that the destructor decl hadn't been created yet, but I see now that you're saying something more subtle. `CurContext` is set to the destructor because the standard says in [class.dtor]p13: At the point of definition of a virtual destructor

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

AntonYudintsev added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define ds

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:695 + DeclRelationSet Relations = DeclRelation::Underlying; + auto Decls = getExplicitDeclAtPosition(AST, SourceLocationBeg, Relations); if (Decls.empty()) instead of creating a n

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 _

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Tue, Jan 07, 2020 at 04:57:29PM -0800, Eric Christopher wrote: > >  ; CHECK-EP-VECTORIZER-START-NEXT: Running pass: NoOpFunctionPass > > +; CHECK-EXT: Running pass: {{.*}}::Bye on foo > > > > Why is this running on every test of the pass manager? It should be an > example >

[clang] 903e5c3 - AArch64: add missing Apple CPU names and use them by default.

Author: Tim Northover Date: 2020-01-08T09:24:06Z New Revision: 903e5c3028d61481c570c09eeb5e7a920c2d7d38 URL: https://github.com/llvm/llvm-project/commit/903e5c3028d61481c570c09eeb5e7a920c2d7d38 DIFF: https://github.com/llvm/llvm-project/commit/903e5c3028d61481c570c09eeb5e7a920c2d7d38.diff LOG:

[PATCH] D70779: AArch64: add support for newer Apple CPUs

t.p.northover closed this revision. t.p.northover added a comment. Thanks Ahmed, pushed: To github.com:llvm/llvm-project.git 0a4daff6e26f..903e5c3028d6 master -> master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70779/new/ https://reviews.llvm.org/D70779 _

[PATCH] D72271: [Clang] Handle target-specific builtins returning aggregates.

simon_tatham updated this revision to Diff 236778. simon_tatham marked an inline comment as done. simon_tatham edited the summary of this revision. simon_tatham added a comment. Restructured as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:89 + +const auto *Lookup = +Result.Nodes.getNodeAs("templateADLexpr"); logan-5 wrote: > JonasToth wrote: > > Can't you just bind directly to the

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236780. njames93 marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp clang-tools-extra/clang-tidy/readability/CMak

[PATCH] D72390: [www] Remove stale text about default c++ standard from cxx_status.html

russell.gallop created this revision. russell.gallop added reviewers: rsmith, t.p.northover. Herald added a project: clang. Since r320250 c++98 is no longer the default, but cxx_status.html still said it was. I think the original intent of the statement was to say that clang by default supports

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

JonasToth added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-reserved-identifier.rst:34 + If non-zero, inverts the check, i.e. flags names that are not reserved. + Default is `0`. + i think you need double-tick here. The hi

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. In D72217#1809212 , @Eugene.Zelenko wrote: > By the word, will be interesting to see results of this check run on LLVM > code. Probably results should be split on modules. So ran it on clang and clang-tidy just crashed, gonna

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

dende added a comment. This is a really useful feature for fuzzing bigger software projects and the review was accepted. Any plans to merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 _

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. In D72217#1809685 , @njames93 wrote: > In D72217#1809212 , @Eugene.Zelenko > wrote: > > > By the word, will be interesting to see results of this check run on LLVM > > code. Probably resu

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:393 +// Converts a string of the form `word1-word2-...` into `Word1 Word2 ...`. +std::string beautify(llvm::StringRef Input) { + std::string Res; It's worth noting that an alternativ

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

Abpostelnicu updated this revision to Diff 236796. Abpostelnicu added a comment. Added more tesst for templa functions that are not instantiated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/new/ https://reviews.llvm.org/D72333 Files: cla

Re: [clang-tools-extra] d2c9c91 - Move from a long list of checkers to tables

[adding the list back] This list is one of the places that would be quite boring and error-prone to update manually. I'd strongly prefer to have an automatic way of updating it. Detecting whether a check has a fix might be not an easy task though. Maybe the script could use some simple heuristic t

[PATCH] D72329: [ARM, MVE] Intrinsics for variable shift instructions.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. I imagine trying to read what a llvm.arm.mve.vshl means in IR would be quite difficult, but it does make lowering them simpler. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

Sure. Will do. Thanks! > On Jan 7, 2020, at 5:17 PM, Akira Hatanaka wrote: > >  >> >>> On Jan 7, 2020, at 2:45 PM, Ben D. Jones via Phabricator via cfe-commits >>> wrote: >>> >>> bendjones added a comment. >>> >>> In D70284#1752806 , @bendjones >>>

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. With this patch the `findReferences` API will return Xref for macros. If the symbol under the cursor is a macro t

[PATCH] D72328: [ARM,MVE] Intrinsics for partial-overwrite imm shifts.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM I think Comment at: clang/utils/TableGen/MveEmitter.cpp:1105 +int Num = Op->getValueAsInt("num"), Denom = Op->getValueAsInt("denom"); +unsigned desiredSize = S

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

MyDeveloperDay added a comment. This LGTM, thanks for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/ https://reviews.llvm.org/D72276 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D72233: Add a new AST matcher 'optionally'.

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:282 REGISTER_MATCHER(hasInitStatement); + REGISTER_MATCHER(hasInitializer); REGISTER_MATCHER(hasKeywordSelector); air20 wrote: > aaron.ballman wrote: > > air20 wrot

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61306 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `gi

[clang] 55a51e1 - Disallow an empty string literal in an asm label

Author: Aaron Ballman Date: 2020-01-08T08:38:02-05:00 New Revision: 55a51e1c79a21080289ba88d5eac4bbe54ec4272 URL: https://github.com/llvm/llvm-project/commit/55a51e1c79a21080289ba88d5eac4bbe54ec4272 DIFF: https://github.com/llvm/llvm-project/commit/55a51e1c79a21080289ba88d5eac4bbe54ec4272.diff

[PATCH] D72375: Disallow an empty string literal in an asm label

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in 55a51e1c79a21080289ba88d5eac4bbe54ec4272 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72375/new/ https://reviews.llvm.org/D72375 ___

[PATCH] D72375: Disallow an empty string literal in an asm label

aaron.ballman accepted this revision. aaron.ballman added a comment. Accepting based on @rjmccall's LG so I can close. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72375/new/ https://reviews.llvm.org/D72375 ___ cfe-commits mailing list cfe

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

JonasToth added a comment. In D72217#1809721 , @njames93 wrote: > In D72217#1809685 , @njames93 wrote: > > > In D72217#1809212 , > > @Eugene.Zelenko wrote: > > > > > By the

[clang] 7a77ad1 - Fixing a formatting nit; NFC

Author: Aaron Ballman Date: 2020-01-08T08:53:04-05:00 New Revision: 7a77ad144694ced7b553c644bcbcbfffac2b5fe1 URL: https://github.com/llvm/llvm-project/commit/7a77ad144694ced7b553c644bcbcbfffac2b5fe1 DIFF: https://github.com/llvm/llvm-project/commit/7a77ad144694ced7b553c644bcbcbfffac2b5fe1.diff

Re: [clang-tools-extra] d2c9c91 - Move from a long list of checkers to tables

Le 08/01/2020 à 14:14, Alexander Kornienko a écrit : [adding the list back] This list is one of the places that would be quite boring and error-prone to update manually. I'd strongly prefer to have an automatic way of updating it. Detecting whether a check has a fix might be not an easy task tho

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM! Thank you for fixing this issue. Can you please update the bug report as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/n

[PATCH] D72167: Add support for __declspec(guard(nocf))

ajpaverd updated this revision to Diff 236806. ajpaverd added a comment. - Make guard_nocf an attribute of individual call instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72167/new/ https://reviews.llvm.org/D72167 Files: clang/include

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

JonasToth added a comment. In D72217#1807941 , @njames93 wrote: > What do you think about volatile qualifiers. Personally I don't think its > important to qualify an volatile on a pointer that is volatile, but i should > adhere to the decl being declared

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

JonasToth added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:402 `hicpp-vararg `_, `cppcoreguidelines-pro-type-vararg `_, + `llvm-qualified-auto `_, `readability-qualified-auto `_, "Yes" That line needs to land above wh

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:463 + } + // Query the index for references from other files. + if (Index && Results.References.size() < Limit) { could we merge this and the code for decls by only popu

[clang-tools-extra] ba129c7 - [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

Author: Andi-Bogdan Postelnicu Date: 2020-01-08T16:36:13+02:00 New Revision: ba129c7d0f5c7c32398ad708c88e14cb06a339ad URL: https://github.com/llvm/llvm-project/commit/ba129c7d0f5c7c32398ad708c88e14cb06a339ad DIFF: https://github.com/llvm/llvm-project/commit/ba129c7d0f5c7c32398ad708c88e14cb06a33

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1021 TEST(FindReferences, NeedsIndex) { + const char *Header = (R"cpp( nit: i don't think there's much benefit in combining refs for macros and symbols in a single

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-reserved-identifier.rst:34 + If non-zero, inverts the check, i.e. flags names that are not reserved. + Default is `0`. + JonasToth wrote: > i think you need

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGba129c7d0f5c: [clang-tidy] Disable match on `if constexpr` statements in template… (authored by Andi-Bogdan Postelnicu ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

capn added a comment. Thanks for the review! I don't have committer access, feel free to land at your convenience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72276/new/ https://reviews.llvm.org/D72276

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146 +- New alias :doc:`llvm-qualified-auto + ` to njames93 wrote: > Eugene.Zelenko wrote: > > Please move alias entry into aliases section. See previous release for > >

[clang] c74a8ad - [OPENMP]Allow comma in combiner expression.

Author: Alexey Bataev Date: 2020-01-08T10:00:11-05:00 New Revision: c74a8adda3bc4fc5714aef14cdcfda944d3038a0 URL: https://github.com/llvm/llvm-project/commit/c74a8adda3bc4fc5714aef14cdcfda944d3038a0 DIFF: https://github.com/llvm/llvm-project/commit/c74a8adda3bc4fc5714aef14cdcfda944d3038a0.diff

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:43 + Whitelist( + utils::options::parseStringList(Options.get("Whitelist", "swap"))) {} + JonasToth wrote: > logan-5 wrote: > > JonasToth wrote

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

sfertile added a comment. LGTM: I really didn't like setting PIC as the default just to work around some codegen bugs. I believe there are PowerPC codegen tests that will fail with this change though (or perhaps there is a PowerPC leak sanitizer build bot which begins to fail? @stefanp probably

Re: [clang-tools-extra] d2c9c91 - Move from a long list of checkers to tables

On Wed, Jan 8, 2020 at 2:45 PM Sylvestre Ledru wrote: > Le 08/01/2020 à 14:14, Alexander Kornienko a écrit : > > [adding the list back] > > > > This list is one of the places that would be quite boring and > error-prone to update manually. I'd strongly prefer to have an automatic > way of updatin

[PATCH] D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements

njames93 added a comment. Is this good to land and if so anyone able to commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71980/new/ https://reviews.llvm.org/D71980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

thakis added a comment. This broke tests on Windows: http://45.33.8.238/win/5297/step_8.txt (probably due to windows using -fdelayed-template-parsing by default). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/new/ https://reviews.llvm.org/D7

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236827. njames93 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp clang-tools-extra/clang-tidy/readability/CMak

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 marked an inline comment as done. njames93 added a comment. In D72217#1809887 , @JonasToth wrote: > In D72217#1809721 , @njames93 wrote: > > > In D72217#1809685 , @n

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

usaxena95 updated this revision to Diff 236829. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72395/new/ https://reviews.llvm.org/D72395 Files: clang-tool

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146 +- New alias :doc:`llvm-qualified-auto + ` to njames93 wrote: > Eugene.Zelenko wrote: > > njames93 wrote: > > > Eugene.Zelenko wrote: > > > > Please move alias entry

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

Abpostelnicu added a comment. I think the best approach here is to remove the tests that don’t have template instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/new/ https://reviews.llvm.org/D72333 ___

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

usaxena95 marked 2 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:463 + } + // Query the index for references from other files. + if (Index && Results.References.size() < Limit) { kadircet w

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61307 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146 +- New alias :doc:`llvm-qualified-auto + ` to Eugene.Zelenko wrote: > njames93 wrote: > > Eugene.Zelenko wrote: > > > njames93 wr

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

eandrews added a comment. Thanks for taking a look Erich! > I'm concerned about just making this fallthrough to 'false'. These ARE > integral promotions, we just don't know the type size. In this case, when integral promotion is skipped, boolean conversion (C++ 4.12) is done instead when parsi

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146 +- New alias :doc:`llvm-qualified-auto + ` to njames93 wrote: > Eugene.Zelenko wrote: > > njames93 wrote: > > > Eugene.Zelenko wrote: > > > > njames93 wrote: > > > >

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236833. njames93 marked 4 inline comments as done. njames93 added a comment. Those pesky new lines CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.c

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146 +- New alias :doc:`llvm-qualified-auto + ` to Eugene.Zelenko wrote: > njames93 wrote: > > Eugene.Zelenko wrote: > > > njames93 wrote: > > > > Eugene.Zelenko wrote: > > > >

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. Ping again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71467/new/ https://reviews.llvm.org/D71467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D71594: testing clang-tidy

alexfh added a comment. What version of clang-tidy and clang-format does this run? Whatever is available in Debian packages? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71594/new/ https://reviews.llvm.org/D71594 __

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet marked 23 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:393 +// Converts a string of the form `word1-word2-...` into `Word1 Word2 ...`. +std::string beautify(llvm::StringRef Input) { + std::string Res; --

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

kadircet updated this revision to Diff 236842. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71555/new/ https://reviews.llvm.org/D71555 Files: clang-tools-ex

[PATCH] D72401: Fixes for spaces around C# object initializers

jbcoe created this revision. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jbcoe added reviewers: MyDeveloperDay, klimek. Fix spaces around typename and [] in C# object initializers. Handling of newlines and binpacking will be addresse

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

lebedev.ri updated this revision to Diff 236843. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. s/1/true/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72362/new/ https://reviews.llvm.org/D72362 Files: clang-tools-extra

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61307 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72221: Support function attribute patchable_function_entry

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for all of the work that went into this. Looks like review comments have all been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 5936717 - Fix "pointer is null" static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-08T17:19:08Z New Revision: 5936717fa6537812257990143e2384bb78486ef9 URL: https://github.com/llvm/llvm-project/commit/5936717fa6537812257990143e2384bb78486ef9 DIFF: https://github.com/llvm/llvm-project/commit/5936717fa6537812257990143e2384bb78486ef9.diff LOG:

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

thakis added a comment. In D72333#1810142 , @Abpostelnicu wrote: > I think the best approach here is to remove the tests that don’t have > template instantiation. In any case, if it takes a while to come to some decision, please revert in the meantime

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux updated this revision to Diff 236838. yroux added a comment. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Hi, here is an update for the Machine Outliner support on ARM targets. It addresses the comments received on the initial version and is rebased on c

[PATCH] D71555: [clangd] Refurbish HoverInfo::present

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great stuff, let's finally ship it! Comment at: clang-tools-extra/clangd/Hover.cpp:466 + markup::Paragraph &P = Output.addParagraph(); + P.appendText(beautify(index::

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:5333 + // We need a layer of indirection because early machine code passes balk at + // physical register (i.e. FFR) uses that have no previous definition. + let hasSideEffects = 1, hasNoSc

[PATCH] D72014: [PowerPC]: Add powerpcspe target triple subarch component

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72014/new/ https://reviews.llvm.org/D72014 ___ cfe-

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

tejohnson added a comment. In D70765#1807609 , @dankamongmen wrote: > > Typically the author commits the patch, unless they don't have commit > > access and request the reviewer to commit for them, but I don't see a > > request for that here. > > Thanks

[PATCH] D72221: Support function attribute patchable_function_entry

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72221/new/ https://reviews.llvm.org/D72221 ___ cfe-commits mailing list cfe-comm

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

Abpostelnicu added a comment. Will push shortly an update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/new/ https://reviews.llvm.org/D72333 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D72271: [Clang] Handle target-specific builtins returning aggregates.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4351 +default: + llvm_unreachable("Bad evaluation kind in EmitBuiltinExpr"); +} We generally don't add `default` cases to exhaustive switches. You can put this `llvm_unreac

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

thakis added a comment. Any luck? The bot's been broken for close to 4h now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/new/ https://reviews.llvm.org/D72333 ___ cfe-commits mailing list cfe-co

[clang-tools-extra] 0a01ec9 - [clang-tidy] Remove broken test on Windows for `readability-misleading-indentation`.

Author: Andi-Bogdan Postelnicu Date: 2020-01-08T20:37:23+02:00 New Revision: 0a01ec972d2e24c721f46e55210d42391ae52b70 URL: https://github.com/llvm/llvm-project/commit/0a01ec972d2e24c721f46e55210d42391ae52b70 DIFF: https://github.com/llvm/llvm-project/commit/0a01ec972d2e24c721f46e55210d42391ae52

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236859. njames93 added a comment. better template support, still runs on llvm and clang libs just fine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModu

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:43 + Whitelist( + utils::options::parseStringList(Options.get("Whitelist", "swap"))) {} + JonasToth wrote: > JonasToth wrote: > > logan-5 wro

[PATCH] D72363: [PowerPC] Default ppc64 linux-gnu/freebsd to -fno-PIC

MaskRay added a comment. In D72363#1810036 , @sfertile wrote: > LGTM: I really didn't like setting PIC as the default just to work around > some codegen bugs. I believe there are PowerPC codegen tests that will fail > with this change though (or perhaps

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added a comment. Repeating for emphasis: This is awesome. :) Having the opt-in //option// to not-ignore overloaded operators is good; please keep that option (in case anyone tries to talk you into removing it). For more than you wanted to know about ADL, why it's bad for library wri

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay planned changes to this revision. MaskRay added a comment. @ostannard @nickdesaulniers @peter.smith Unfortunately we will have to get buy-in from GCC before committing to do an incompatible design. A promise that they will implement a new approach to overcome the disadvantages and an ag

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72233: Add a new AST matcher 'optionally'.

air20 updated this revision to Diff 236866. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72233/new/ https://reviews.llvm.org/D72233 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h clang/include/clang/ASTMatchers/ASTMatchersInternal.h

[PATCH] D71842: Allow newlines in AST Matchers in clang-query files

ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/Dynamic/Parser.h:167 static llvm::Optional - parseMatcherExpression(StringRef MatcherCode, Sema *S, - const NamedValueMap *NamedValues, - Diagnostics *Er

[PATCH] D72233: Add a new AST matcher 'optionally'.

air20 marked an inline comment as done. air20 added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:282 REGISTER_MATCHER(hasInitStatement); + REGISTER_MATCHER(hasInitializer); REGISTER_MATCHER(hasKeywordSelector); aaron.ballman wrot

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

lebedev.ri added a comment. Land this? (branching is near..) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71499/new/ https://reviews.llvm.org/D71499 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] 2823e91 - Add a new AST matcher 'optionally'.

Author: Rihan Yang Date: 2020-01-08T14:10:11-05:00 New Revision: 2823e91d55891e33a7a8b9a4016db4ec9e2765ae URL: https://github.com/llvm/llvm-project/commit/2823e91d55891e33a7a8b9a4016db4ec9e2765ae DIFF: https://github.com/llvm/llvm-project/commit/2823e91d55891e33a7a8b9a4016db4ec9e2765ae.diff LO

[PATCH] D72233: Add a new AST matcher 'optionally'.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've commit on your behalf in 2823e91d55891e33a7a8b9a4016db4ec9e2765ae CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72233/n

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen created this revision. zahen added reviewers: rnk, thakis, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch adding a new /D flag when compiling a source file that consumed a PCH with clang-cl would issue a diagnostic and then fail. With the pa

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun updated this revision to Diff 236873. xazax.hun added a comment. - Prepopulating the worklist for UninitializedValues seems to be redundant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72380/new/ https://reviews.llvm.org/D72380 Files: clang/include/clang/Analysis/FlowSens

[clang] 43f938e - LTOVisibility.rst: fix up syntax in example

Author: Teresa Johnson Date: 2020-01-08T11:43:11-08:00 New Revision: 43f938eddc8a5c8e12c116ca5f31df5a6fead24e URL: https://github.com/llvm/llvm-project/commit/43f938eddc8a5c8e12c116ca5f31df5a6fead24e DIFF: https://github.com/llvm/llvm-project/commit/43f938eddc8a5c8e12c116ca5f31df5a6fead24e.diff

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun added a comment. Fortunately, UninitializedValues has some statistics. So I printed it for a big translation unit (SemaExpr.cpp) before and after this change. Before: *** Analysis Based Warnings Stats: 33023 functions analyzed (0 w/o CFGs). 161696 CFG blocks built. 4 avera

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:31 + Const, + Volatile // Ignore restrict as not c++ keyword. +}; We still support `restrict` in C++ though: https://godbolt.org/z/CT5nw2 Also, one

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

This revision was automatically updated to reflect the committed changes. Closed by commit rG43f938eddc8a: LTOVisibility.rst: fix up syntax in example (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70765/new/ https://reviews.

[PATCH] D72121: [clang-tidy] Fix readability-identifier-naming missing member variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming-member-decl-usage.cpp:137 +} +}; // namespace CtorInits

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

mgehre added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowWorklist.h:20 +namespace clang { +template class DataflowWorklistBase { + llvm::BitVector EnqueuedBlocks; Should this class have a bit of doxygen and a unit test? CHA

  1   2   >