kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/XRefs.cpp:463
+ }
+ // Query the index for references from other files.
+ if (Index && Results.References.size() < Limit) {
----------------
could we merge this and the code for decls by only populating `Req.IDs` with
`MacroSID` here and with the symbol id below and by finally making the query in
the end ? i.e.
```
RefsRequest Req;
Req.Limit = Limit;
if (macro) {
handleMainFileMacros;
Req.IDs.insert(*MacroID);
} else {
handleMainFileDecls;
populateReqIDs(Req);
}
handleIndexResults(Req);
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72395/new/
https://reviews.llvm.org/D72395
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
