kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/XRefs.cpp:695 + DeclRelationSet Relations = DeclRelation::Underlying; + auto Decls = getExplicitDeclAtPosition(AST, SourceLocationBeg, Relations); if (Decls.empty()) ---------------- instead of creating a new function, could you rather inline that ? it is the only call site and almost the same with `getDeclAtPosition`. the comment above (with little modifications) should suffice to explain why `getDeclAtPosition` is not used here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71533/new/ https://reviews.llvm.org/D71533 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
