frankvicky commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2025822378
##########
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##########
@@ -87,7 +87,7 @@ public FetchResponseData data() {
* We may also return INCONSISTENT_TOPIC_ID error as a partition-level
error when a partition in the session has a topic ID
* inconsistent with the log.
*/
- public FetchResponse(FetchResponseData fetchResponseData) {
+ FetchResponse(FetchResponseData fetchResponseData) {
Review Comment:
According to
https://github.com/apache/kafka/pull/19167#discussion_r2024085572
If we have a private scope for the constructor, the request `version <
13`[0] will have an overhead (iterate 2 times).
If we worry about the wrongly invoked constructor, we could add a Javadoc to
it. Although it's not good protection, it seems like a tradeoff between code
style consistency and performance.
WDYT?
[0]
https://github.com/apache/kafka/blob/e4792c4b01b3127b0019b5469c51e72b96876e7d/clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java#L353-L362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
