junrao commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2021826376
##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -583,6 +583,66 @@ public void testFetchResponseV4() {
deserialized.responseData(topicNames, (short) 4));
}
+ @Test
+ public void testFetchResponseShouldNotHasNullRecords() {
Review Comment:
Has => Have
##########
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchResponse.java:
##########
@@ -156,6 +163,23 @@ public static int
recordsSize(ShareFetchResponseData.PartitionData partition) {
return partition.records() == null ? 0 :
partition.records().sizeInBytes();
}
+ /**
+ * Creates a {@link org.apache.kafka.common.requests.ShareFetchResponse}
from the given data.
+ * This method converts null records to {@link
org.apache.kafka.common.record.MemoryRecords#EMPTY}
+ * to ensure consistent record representation in the response.
+ *
+ * <p><strong>This method should only be used in server-side.</strong></p>
+ */
+ public static ShareFetchResponse of(ShareFetchResponseData data) {
Review Comment:
Could we get rid of this constructor and direct all callers to the other
`of` constructor?
##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -583,6 +583,66 @@ public void testFetchResponseV4() {
deserialized.responseData(topicNames, (short) 4));
}
+ @Test
+ public void testFetchResponseShouldNotHasNullRecords() {
+ Uuid id = Uuid.randomUuid();
+ FetchResponseData.PartitionData partitionData = new
FetchResponseData.PartitionData()
+ .setPartitionIndex(0)
+ .setHighWatermark(1000000)
+ .setLogStartOffset(100)
+ .setLastStableOffset(200)
+ .setRecords(null);
+ FetchResponseData.FetchableTopicResponse response = new
FetchResponseData.FetchableTopicResponse()
+ .setTopic("topic")
+ .setPartitions(List.of(partitionData))
+ .setTopicId(id);
+ FetchResponseData data = new
FetchResponseData().setResponses(List.of(response));
+
+ response.setPartitions(List.of(FetchResponse.partitionResponse(0,
Errors.NONE)));
+ FetchResponse fetchResponse = FetchResponse.of(data);
+ validateNoNullRecords(fetchResponse);
+
+ TopicIdPartition topicIdPartition = new TopicIdPartition(id, new
TopicPartition("test", 0));
+ LinkedHashMap<TopicIdPartition, FetchResponseData.PartitionData>
tpToData = new LinkedHashMap<>(Map.of(topicIdPartition, partitionData));
+ fetchResponse = FetchResponse.of(Errors.NONE, 0, INVALID_SESSION_ID,
tpToData);
+ validateNoNullRecords(fetchResponse);
+ }
+
+ private void validateNoNullRecords(FetchResponse fetchResponse) {
+ fetchResponse.data().responses().stream()
+ .flatMap(response -> response.partitions().stream())
+ .forEach(partition -> assertEquals(MemoryRecords.EMPTY,
partition.records()));
+ }
+
+ @Test
+ public void testShareFetchResponseShouldNotHasNullRecords() {
Review Comment:
Has => Have
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
