junrao commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2015116293
##########
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##########
@@ -89,7 +89,7 @@ public FetchResponseData data() {
*/
public FetchResponse(FetchResponseData fetchResponseData) {
super(ApiKeys.FETCH);
- this.data = fetchResponseData;
+ this.data = convertNullRecordsToEmpty(fetchResponseData);
Review Comment:
This code is called by both the server and the client. On the server side,
it makes sense for the server to set records to empty. On the client side, it
seems that it's better to take whatever it receives from the broker, instead of
changing it silently. Maybe we can consolidate the server side usage based on
FetchResponse.of() and the client side usage based on FetchResponse.parse(),
and avoid the direct usage of this constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
