Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

[via GitHub]

frankvicky commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2018839958


##########
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##########
@@ -89,7 +89,7 @@ public FetchResponseData data() {
      */
     public FetchResponse(FetchResponseData fetchResponseData) {
         super(ApiKeys.FETCH);
-        this.data = fetchResponseData;
+        this.data = convertNullRecordsToEmpty(fetchResponseData);

Review Comment:
   
https://github.com/apache/kafka/blob/28de78bcbad605a3e906d085d2e59b441ae35212/core/src/main/scala/kafka/server/KafkaApis.scala#L3104-L3111
   
   
https://github.com/apache/kafka/blob/28de78bcbad605a3e906d085d2e59b441ae35212/core/src/main/scala/kafka/server/KafkaApis.scala#L3121-L3125
   
   I'm not familiar with the queues feature. Should we add 
`MemoryRecords.Empty` for these two parts?
   cc @AndrewJSchofield 
   
   Many thanks 🙇🏼 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org