frankvicky commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2009992877
##########
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##########
@@ -286,4 +291,12 @@ private static FetchResponseData toMessage(Errors error,
.setSessionId(sessionId)
.setResponses(topicResponseList);
}
+
+ private static FetchResponseData
convertNullRecordsToEmpty(FetchResponseData fetchResponseData) {
+ fetchResponseData.responses().stream()
+ .flatMap(response -> response.partitions().stream())
+ .filter(partition -> partition.records() == null)
+ .forEach(partition -> partition.setRecords(MemoryRecords.EMPTY));
Review Comment:
Indeed.
For a perf-sensitive fetch path, the stream operations are adding
unnecessary stream creation overhead and lambda invocation costs. 🙇🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
