chia7712 commented on code in PR #19167:
URL: https://github.com/apache/kafka/pull/19167#discussion_r2026260113
##########
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##########
@@ -87,7 +87,7 @@ public FetchResponseData data() {
* We may also return INCONSISTENT_TOPIC_ID error as a partition-level
error when a partition in the session has a topic ID
* inconsistent with the log.
*/
- public FetchResponse(FetchResponseData fetchResponseData) {
+ FetchResponse(FetchResponseData fetchResponseData) {
Review Comment:
> Looking at the relevant commit, it seems like the double iteration is only
for the error handling case. That doesn't seem a major issue, if true.
yes, that is not hot path. I'm fine with private constructor :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
