epugh commented on PR #3263: URL: https://github.com/apache/solr/pull/3263#issuecomment-2736428011
> damn this PR is massive @mlbiscoc asked me about if he should break it up via Slack, and i didn't have a good answer... I know that breaking up PR's can be time consuming and introduce it's own bugs, and a big part of me just wants to get to "done done" on this journey... So I left it as "it's big, but it's only one thing"... He did bring up the "break it up" idea and I didn't encourage it, so if that is a big mistake, thats on me! I love that work that is happening here. I will say, as I attempted to go through it, I did wonder about the breaking it up, it's a daunting PR to review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
