mlbiscoc commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r2001922464
##########
solr/core/src/test/org/apache/solr/schema/TestSchemalessBufferedUpdates.java:
##########
@@ -57,19 +59,17 @@ public class TestSchemalessBufferedUpdates extends
SolrTestCaseJ4 {
@BeforeClass
public static void beforeClass() throws Exception {
- File tmpSolrHome = createTempDir().toFile();
- File tmpConfDir = new File(tmpSolrHome, confDir);
- File testHomeConfDir = new File(TEST_HOME(), confDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir, "solrconfig-schemaless.xml"), tmpConfDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir,
"schema-add-schema-fields-update-processor.xml"), tmpConfDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir, "solrconfig.snippet.randomindexconfig.xml"),
tmpConfDir);
+ Path tmpSolrHome = createTempDir();
+ Path tmpConfDir = FilterPath.unwrap(tmpSolrHome.resolve(confDir));
Review Comment:
`java.nio.file.ProviderMismatchException: mismatch, expected: FilterPath,
got: class sun.nio.fs.UnixPath`
`createTempDir()` returns a
[filterPath](https://github.com/apache/lucene/blob/a2c6d3a1c6565b7ff2eef2a5b84a91cf8f8b1ffc/lucene/test-framework/src/java/org/apache/lucene/tests/mockfile/FilterPath.java#L38).
From Lucene test-framework, seems you can only resolve a FilterPath with
another FilterPath.
So I unwrap it to get the underlying Path instead of Filterpath allowing
`resolve` being called inside of `PathUtils.copyFileToDirectory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
