dsmiley commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r2001677532
##########
solr/core/src/test/org/apache/solr/cli/StreamToolTest.java:
##########
@@ -185,11 +183,11 @@ public void testReadStream() throws Exception {
@Test
@SuppressWarnings({"unchecked", "rawtypes"})
public void testLocalCatStream() throws Exception {
- File localFile = File.createTempFile("topLevel1", ".txt");
- populateFileWithData(localFile.toPath());
+ Path localFile = Files.createTempFile("topLevel1", ".txt");
+ populateFileWithData(localFile);
StreamTool.LocalCatStream catStream =
- new StreamTool.LocalCatStream(localFile.getAbsolutePath(), -1);
+ new StreamTool.LocalCatStream(localFile.toAbsolutePath().toString(),
-1);
Review Comment:
agreed to leave CatStream be. I *could* see adding a Path convenience
constructor there but it's out of scope of this PR IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
