dsmiley commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r2001692267
##########
solr/core/src/test/org/apache/solr/cli/SolrProcessManagerTest.java:
##########
@@ -84,9 +83,11 @@ private static int findAvailablePort() throws IOException {
private static Pair<Integer, Process> createProcess(int port, boolean https)
throws IOException {
// Get the path to the java executable from the current JVM
String classPath =
-
Arrays.stream(System.getProperty("java.class.path").split(File.pathSeparator))
+ Arrays.stream(
+
System.getProperty("java.class.path").split(System.getProperty("path.separator")))
Review Comment:
I'm good with your replacement, albeit it'd be slightly nicer to declare a
variable to hold the value as you're going to refer to it multiple times. NIO
has no alternative. It's easier to just ban File and use this more awkward
lookup because it's so rare to actually use this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
