dsmiley commented on code in PR #3263: URL: https://github.com/apache/solr/pull/3263#discussion_r2001737258
########## solr/core/src/test/org/apache/solr/cloud/TestTolerantUpdateProcessorCloud.java: ########## @@ -95,10 +95,9 @@ public class TestTolerantUpdateProcessorCloud extends SolrCloudTestCase { public static void createMiniSolrCloudCluster() throws Exception { final String configName = "solrCloudCollectionConfig"; - final File configDir = - new File(TEST_HOME() + File.separator + "collection1" + File.separator + "conf"); + final Path configDir = TEST_HOME().resolve("collection1").resolve("conf"); Review Comment: LOVE THIS. It exemplifies the improvements in this PR, and the sad state of half/partial usage of NIO before that so needed some love. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org