dsmiley commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r2001038145
##########
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandlerNonCloud.java:
##########
@@ -32,17 +32,17 @@
public class TestSQLHandlerNonCloud extends SolrJettyTestBase {
- private static File createSolrHome() throws Exception {
- File workDir = createTempDir().toFile();
+ private static Path createSolrHome() throws Exception {
+ Path workDir = createTempDir();
setupJettyTestHome(workDir, DEFAULT_TEST_COLLECTION_NAME);
return workDir;
}
@BeforeClass
public static void beforeClass() throws Exception {
- File solrHome = createSolrHome();
- solrHome.deleteOnExit();
- createAndStartJetty(solrHome.getAbsolutePath());
+ Path solrHome = createSolrHome();
+ solrHome.toFile().deleteOnExit();
Review Comment:
This is a test, thus any file created is in a temp directory and will be
deleted _anyway_, as that's what the test infrastructure takes care to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
