dsmiley commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r2002380589
##########
solr/solr-ref-guide/modules/deployment-guide/examples/ZkConfigFilesTest.java:
##########
@@ -64,8 +63,7 @@ private void clearConfigs() throws Exception {
@Test
public void testCanUploadConfigToZk() throws Exception {
- final String localConfigSetDirectory =
- new File(ExternalPaths.TECHPRODUCTS_CONFIGSET).getAbsolutePath();
+ final String localConfigSetDirectory =
ExternalPaths.TECHPRODUCTS_CONFIGSET.toString();
Review Comment:
don't actually need this as a String in this method
##########
solr/core/src/test/org/apache/solr/schema/TestSchemalessBufferedUpdates.java:
##########
@@ -57,19 +59,17 @@ public class TestSchemalessBufferedUpdates extends
SolrTestCaseJ4 {
@BeforeClass
public static void beforeClass() throws Exception {
- File tmpSolrHome = createTempDir().toFile();
- File tmpConfDir = new File(tmpSolrHome, confDir);
- File testHomeConfDir = new File(TEST_HOME(), confDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir, "solrconfig-schemaless.xml"), tmpConfDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir,
"schema-add-schema-fields-update-processor.xml"), tmpConfDir);
- FileUtils.copyFileToDirectory(
- new File(testHomeConfDir, "solrconfig.snippet.randomindexconfig.xml"),
tmpConfDir);
+ Path tmpSolrHome = createTempDir();
+ Path tmpConfDir = FilterPath.unwrap(tmpSolrHome.resolve(confDir));
Review Comment:
Interesting. What Lucene is doing makes sense. I dug deeper and found that
the root cause of the problem is in commons-io -- which I just filed a trivial
jira issue for: [IO-870](https://issues.apache.org/jira/browse/IO-870). It's
easy to avoid by not calling `PathUtils.copyFileToDirectory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
