mlbiscoc commented on code in PR #3263:
URL: https://github.com/apache/solr/pull/3263#discussion_r2004282958
##########
solr/core/src/test/org/apache/solr/search/TestRecovery.java:
##########
@@ -1779,11 +1778,11 @@ public void testRecoveryMultipleLogs() throws Exception
{
assertU(adoc("id", "CCCCCC"));
h.close();
- String[] files = ulog.getLogList(logDir.toPath());
+ String[] files = ulog.getLogList(logDir);
Arrays.sort(files);
String fname = files[files.length - 1];
byte[] content;
- try (RandomAccessFile raf = new RandomAccessFile(new File(logDir,
fname), "rw")) {
+ try (RandomAccessFile raf = new
RandomAccessFile(logDir.resolve(fname).toFile(), "rw")) {
Review Comment:
I think I'm going to leave this as is. I found some solutions to this but
don't want to complicate this PR more than it already is. Will be forced to
come back to this anyways because if you want to make File a forbidden API, we
need to remove all the `toFile()` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
