On Thu, 12 Dec 2024 19:06:00 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 20 commits: >> >> - More test clean-ups >> - Merge two AllModulePath tests >> - Better error message with no modules on mod-path and ALL-MODULE-PATH >> - Merge branch 'jdk-8345573-runtime-link-limit-mods' into >> jdk-8345259-all-module-path-fix >> - Mandy's feedback >> - Merge branch 'jdk-8345573-runtime-link-limit-mods' into >> jdk-8345259-all-module-path-fix >> - Handle non-existent module-path with ALL-MODULE-PATH >> - Move test, more test fixes for JEP 493 enabled builds >> - Fix JLinkTest.java >> - 8345259: Disallow ALL-MODULE-PATH without explicit --module-path >> - ... and 10 more: https://git.openjdk.org/jdk/compare/c9643d31...9ba004cc > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 441: > >> 439: // run-time image. Only do this if no --limit-modules >> has been >> 440: // specified to begin with. >> 441: ModuleFinder mf = newLimitedFinder(finder, > > FWIW, rereading this, it's still a bit awk to call a module finder a limited > finder. How about `newScopedFinder()`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1883727390
