On Tue, 10 Dec 2024 23:41:44 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Handle non-existent module-path with ALL-MODULE-PATH
>> - Move test, more test fixes for JEP 493 enabled builds
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/jlink.properties line
> 131:
>
>> 129: \ when running on a patched runtime with --patch-module
>> 130: err.all.module.path.empty.mod.path=ALL-MODULE-PATH requires
>> --module-path option (or --module-path does not exist)
>> 131: err.empty.module.path=empty module path
>
> `err.empty.module.path` is unused and can be modified for this use.
>
> Suggestion:
>
> err.no.module.path=--module-path option must be specified with --add-modules
> ALL-MODULE-PATH
> err.empty.module.path=No module found from the module path {0}
I've updated it and mentioned `ALL-MODULE-PATH` in the error of a non-existing
module path.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1882556559
