On Thu, 12 Dec 2024 19:02:48 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 20 commits: >> >> - More test clean-ups >> - Merge two AllModulePath tests >> - Better error message with no modules on mod-path and ALL-MODULE-PATH >> - Merge branch 'jdk-8345573-runtime-link-limit-mods' into >> jdk-8345259-all-module-path-fix >> - Mandy's feedback >> - Merge branch 'jdk-8345573-runtime-link-limit-mods' into >> jdk-8345259-all-module-path-fix >> - Handle non-existent module-path with ALL-MODULE-PATH >> - Move test, more test fixes for JEP 493 enabled builds >> - Fix JLinkTest.java >> - 8345259: Disallow ALL-MODULE-PATH without explicit --module-path >> - ... and 10 more: https://git.openjdk.org/jdk/compare/c9643d31...9ba004cc > > test/jdk/tools/jlink/basic/AllModulePath.java line 306: > >> 304: .map(s -> { return s.split("@")[0]; >> }) >> 305: .sorted() >> 306: .toList(); > > Suggestion: > > OutputAnalyzer out = ProcessTools.executeCommand(java.toString(), > "--list-modules"); > .shouldHaveExitValue(0); > List<String> actual = out.asLines().stream() > .map(s -> { return s.split("@")[0]; }) > .sorted() > .toList(); Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1883981447
