On Fri, 13 Dec 2024 10:39:36 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 441:
>> 
>>> 439:                 // run-time image. Only do this if no --limit-modules 
>>> has been
>>> 440:                 // specified to begin with.
>>> 441:                 ModuleFinder mf = newLimitedFinder(finder,
>> 
>> FWIW, rereading this, it's still a bit awk to call a module finder a limited 
>> finder.
>
> How about `newScopedFinder()`?

Best to leave out renaming when in doubt - either `newModuleFinder` or 
`limitFinder`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1884352739

Reply via email to