> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH` > without explicit `--module-path` option or a non-existent module path. In > addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and > `--limit-modules` are used in combination. It failed earlier and passes now > due to alignment of `ModuleFinder`s. With this patch JEP 493 enabled builds > and regular JDK builds behave the same in terms of `ALL-MODULE-PATH`. > > When an explicit module path is being added, there is no difference. All > modules on that path will be added as roots. Tests have been added for the > various cases and existing tests updated to allow for them to run on JEP 493 > enabled builds. Thoughts? > > Testing: > - [x] GHA, `test/jdk/tools/jlink` (all pass) > - [x] Added jlink test.
Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision: - Handle non-existent module-path with ALL-MODULE-PATH - Move test, more test fixes for JEP 493 enabled builds ------------- Changes: - all: https://git.openjdk.org/jdk/pull/22494/files - new: https://git.openjdk.org/jdk/pull/22494/files/2f1934f3..74793bab Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=22494&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22494&range=03-04 Stats: 477 lines in 6 files changed: 268 ins; 182 del; 27 mod Patch: https://git.openjdk.org/jdk/pull/22494.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22494/head:pull/22494 PR: https://git.openjdk.org/jdk/pull/22494
