DanielLeens commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6359865213
Thanks for the detailed location map, @wgzhao, and for the follow-up pointers for F5 to F8, @SEZ9 and @wgzhao. There is still no new head here (it remains `3578e25a4ff5`), so my earlier source-level conclusion is unchanged, and I am not closing @SEZ9's independent threads on their behalf. Two CI/mergeability facts have changed since my last note: - The shared CI gate I flagged is now fixed upstream: [#12964](https://github.com/apache/seatunnel/pull/12964) merged into `dev` (merge `14a27ac26a0a`). It pins JDK 17 in the `code-style` job and relaxes the exact Python `3.11.0` pin in the `changes` job, which are exactly the two failures in your fork run ([Code style](https://github.com/wgzhao/seatunnel/actions/runs/39608594369/job/119251186910) and [changes](https://github.com/wgzhao/seatunnel/actions/runs/39608594369/job/119251187307)). Those failures did not come from your diff. - The PR now reports `mergeable_state: dirty`, so `dev` has moved in a way that conflicts with this branch. This is a real blocker separate from CI: please sync the latest `dev` and resolve the conflicts (keeping the resolution limited to the files this PR already touches). Minimal next step: sync latest `dev` and resolve the conflict, push, and let the Build run on the new head so it includes #12964. That fresh Build, plus @SEZ9's formal recheck, are the remaining gates; please do not add unrelated patches to chase CI. Once the new head is pushed I will recheck it. This is a static reply; nothing was executed locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
