wgzhao commented on PR #12904:
URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6310191770
Both recommendations are addressed in the latest head `21780a760`:
- The refresh-warning test now mocks `useMessage().warning` and asserts the
behavior rather than
relying on an auto-dismissed toast: the first error warns, an identical
consecutive error does
not warn again, a changed error warns again, and after a successful
refresh the same error warns
once more (proving the streak state was reset).
- Renamed `shouldReturnJobIdOnlyWhenFinishedMetricsIsMissing` to
`shouldReturnFinishedPayloadWithEmptyMetricsWhenMetricsAreMissing`.
The branch is rebased onto the latest `dev` (`bab2d089c`). Validation: UI
`detail.spec.ts` 7
tests, server `JobInfoServiceNullSafetyTest` 8 tests, `vue-tsc`, `prettier
--check` and
`spotless:apply` pass.
The new head will re-run CI. `bab2d089c` is a Parquet/Spark fix, so it does
not address the base
`LLMBooleanOutputTest` serialVersionUID failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
