wgzhao commented on PR #12904:
URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6357872412
Thanks @SEZ9 — it looks like my previous comment was truncated on your side
after "HTTP 404 branch (". Re-pasting the missing pieces, plus the F6–F8
pointers you asked for (all on head `3578e25a4`).
- **F5** — `seatunnel-cli/seatunnel_cli/cli.py:1657` is the `run_diagnose`
HTTP 404 branch where the "id may be wrong" wording now lives.
- **F6** —
`seatunnel-engine/seatunnel-engine-ui/src/views/jobs/detail.tsx:139-154`: the
`catch` in `fetch()` shows the full error card for an initial-load failure, and
after a successful load keeps the populated page (one warning per error streak)
while retrying on the next tick. Covered by `detail.spec.ts` cases "should show
an error result when getJobInfo rejects" and "should keep the loaded job when a
refresh is rejected".
- **F7** — `tools/seatunnel-python-sdk/seatunnel/endpoints/jobs.py:90-105`:
`job_exists` raises `TypeError` for a non-dictionary/non-JSON body at `:100`,
and only then checks `found` at `:104-105`, so "server said absent" and
"unexpected response shape" are no longer conflated. Covered by `test_sdk.py`.
- **F8** — `detail.tsx:616` renders the missing-state description via
`t('detail.notFound.description', { jobId })`; `detail.spec.ts` asserts the
route id (`123456789`) is shown.
F6–F8 were already included in my previous reply as points 3 and 4 — the
truncation just hid them. Nothing else to change on those three; let me know if
you want any additional pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
