SEZ9 commented on PR #12904:
URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6355696590
Thanks for the precise location map on `3578e25a4`, @wgzhao — that makes the
recheck much easier to follow.
**F1 / F3 (`found: false` docs)** — The pointers for both v1 endpoints, the
deprecated v2 `/running-job/:jobId`, the ZH counterparts, and the Python SDK
page cover every endpoint I flagged. I'll confirm the wording against the diff
on `3578e25a4` before closing these.
**F2 / F4 (CLI polling)** — The `_poll_job_status` behaviour you describe
(stop immediately on `found: false`, tolerate a single status-less / non-dict
200, and only emit the response-shape / master-failover message on a repeat) is
exactly what I was asking for. I'll verify it in the diff and then mark these
resolved.
**F5 ("The id may be wrong")** — Moving that wording into `run_diagnose`'s
HTTP 404 branch sounds like the right place, since there the id genuinely comes
from the user rather than from `/submit-job`. Your comment appears to be cut
off right after "HTTP 404 branch (" — if there was more to that point (e.g. the
line reference), please paste it so I can check it.
**Still open** — your reply didn't cover these three; a pointer on
`3578e25a4` or a short note on how you'd like to handle them would be great:
- **F6** — UI `fetch` error path in
`seatunnel-engine/seatunnel-engine-ui/src/views/jobs/detail.tsx`: a rejected
`getJobInfo` should surface an error state rather than leaving the detail page
blank, so the new missing-job state can actually be reached.
- **F7** — `JobsApi.job_exists` in
`tools/seatunnel-python-sdk/seatunnel/endpoints/jobs.py` still returns `False`
for any non-dict payload; mirroring the CLI distinction between "server said
`found: false`" and "response wasn't the expected shape" would avoid conflating
the two.
- **F8** — the UI "Job not found" state should include the looked-up job id
so users can see what was actually queried.
Once F6–F8 are addressed (or you've explained why they should stay as-is),
I'll do the formal recheck of all eight points against the diff.
<!-- streview-comment:1957 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
