SEZ9 commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6306888680
Thanks @wgzhao, the `489dd37c5` approach for the UI error path (PR12904-F6) sounds right: full error card only before the first successful load, a populated page that survives a transient refresh rejection with a single warning per error streak, and retry on the next 5 s tick. Covering the rejection-after-successful-load case in `detail.spec.ts` is exactly the test I was hoping for. Two small follow-ups on that scope: - Does the warning clear once a subsequent refresh succeeds again, so a recovered job does not keep showing a stale error banner? If yes, a one-line note (or an assertion in the new spec case) would make that explicit. - You mention "both remaining Low items" — I read that as F6 plus the "Job not found" state now showing the looked-up job id (PR12904-F8). Could you confirm F8 is in `489dd37c5` as well? If it was already handled in an earlier push, just point me at it. For the rest of the earlier scope, I don't see status in this thread for the docs items (the `found: false` payload on the v1 `/hazelcast/rest/maps/job-info/:jobId` and deprecated `/running-job/:jobId` endpoints, PR12904-F1/F3), the CLI polling behaviour and the "The id may be wrong" message (PR12904-F2/F4/F5), or `JobsApi.job_exists` treating a non-dict payload as "not found" (PR12904-F7). If those were addressed in a previous head, a short summary of what changed where is enough; otherwise let me know which ones you intend to defer. On CI: agreed that `engine-v2-it` on Java 11/17 and `Build SeaTunnel UI` passing for `489dd37c5` is what matters for this PR, and the `LLMBooleanOutputTest` serialVersionUID failures in the `unit-test` jobs are out of scope here given there are no `seatunnel-transforms-v2` changes. Once `dev` moves past `1ce2d7815` with the fix, a rebase should turn the Build green; no action needed from you on that in this PR. <!-- streview-comment:1915 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
