SEZ9 commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6331325167
Thanks @wgzhao — moving `vi.useRealTimers()` into `afterEach` for every test in `detail.spec.ts` in `3578e25a4` addresses the fake-timer hygiene nit, and thanks for running `vitest`, `prettier --check` and `vue-tsc` locally. Before I give the formal approval, I'd like to confirm the earlier review points against the actual changes rather than from the discussion alone. Could you point me to where each of these is handled on the new head (`3578e25a4ff5` on top of `bab2d089c`)? - `found: false` documented for the deprecated v2 `/running-job/:jobId` and both v1 endpoints, not only `/job-info/:jobId` - CLI post-submit polling no longer stopping on a single status-less / non-dict body, and the "The id may be wrong" wording for an id obtained from `/submit-job` - UI `fetch` error path in `detail.tsx` and showing the looked-up job id in the missing-job state - `JobsApi.job_exists` handling of non-dict payloads Once those are confirmed and CI is green on the new head, I'll approve. If any check stays red, please leave a short note here pointing to it so we can confirm on the thread that it is unrelated to this diff. <!-- streview-comment:1933 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
