SEZ9 commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6393017397
Thanks @wgzhao for the pointers on 3578e25a4 / 875a7ff78. **F1 / F3 (found:false docs), F2 / F4 (CLI post-submit polling), F8 (UI not-found shows the job id)** — The locations you listed (the v1 `/job-info` and `/running-job` sections in rest-api-v1.md and the deprecated v2 `/running-job` section in rest-api-v2.md, EN + ZH; `_poll_job_status` in cli.py; the detail.spec.ts assertion that the not-found description renders the route job id 123456789) are exactly what I need. I'll check those spots in the diff on 875a7ff78 and resolve the threads once I've confirmed the content there, rather than closing them from the description alone. Still open from my earlier pass: 1. **F5** — Is the post-submit "The id may be wrong" wording still present for the id the CLI itself received from `/submit-job`? If it was reworded alongside F2/F4, a pointer in cli.py would be enough. 2. **F6** — Does the UI `fetch` in detail.tsx now have an error path for a rejected `getJobInfo`, so the page isn't left blank? A pointer, or a note if you'd prefer to keep this as a follow-up, is fine. 3. **F7** — Has `JobsApi.job_exists` in jobs.py been adjusted so a non-dict/non-JSON payload is not reported as "job does not exist"? Same ask: pointer or explicit deferral. I've noted the green fork run 39919297925 on 875a7ff78. Once I've verified the pointers above and F5–F7 are confirmed or explicitly deferred, I'll have nothing further within this scope; the final merge approval remains with a committer with write access. <!-- streview-comment:2020 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
