On Fri, 30 Aug 2024 21:25:18 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> I added a global typedef klass_flags_t because it didn't look confusing vs >> KlassFlags and KlassFlags_t, and the lower case convention is something we >> usually use for typedefs. > > I agree with Dean. I don't see why the value can't be eagerly captured as > part of `ciKlass` initialization. > > I'm fine with leaving it as is since it follows the existing pattern in > `ciKlass::access_flags()`, so something for a future cleanup. Yes, I agree, this should be saved in ciKlass somewhere, along with access_flags since they are const as well, but I think someone should do this as a follow on. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1739449411
