On Fri, 30 Aug 2024 12:58:17 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> src/hotspot/share/ci/ciKlass.cpp line 233:
>>
>>> 231: jint ciKlass::misc_flags() {
>>> 232: assert(is_loaded(), "not loaded");
>>> 233: GUARDED_VM_ENTRY(
>>
>> To Compiler folks: I don't think the VM_ENTRY is necessary, but if it is,
>> then we should consider entering VM mode once and caching/memoizing these
>> immutable flag values in the ciKlass.
>
> I added a global typedef klass_flags_t because it didn't look confusing vs
> KlassFlags and KlassFlags_t, and the lower case convention is something we
> usually use for typedefs.
I agree with Dean. I don't see why the value can't be eagerly captured as part
of `ciKlass` initialization.
I'm fine with leaving it as is since it follows the existing pattern in
`ciKlass::access_flags()`, so something for a future cleanup.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1739425219
