On Thu, 29 Aug 2024 21:03:09 GMT, Matias Saavedra Silva <matsa...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add in graal flags and a comment. > > src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 694: > >> 692: load_klass(tmp, obj_reg); >> 693: ldrb(tmp, Address(tmp, Klass::misc_flags_offset())); >> 694: tstw(tmp, KlassFlags::_misc_is_value_based_class); > > Should this just be `tst` instead of `tstw`? Yes, thanks, and I changed all of these in the aarch64 code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1738608738
