On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Move JVM implementation access flags that are not specified by the classfile >> format into Klass so we can shrink AccessFlags to u2 in a future change. >> >> Tested with tier1-7. >> >> NOTE: there are arm, ppc and s390 changes to this that are just a guess. >> Also, graal changes. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Add in graal flags and a comment. src/hotspot/share/ci/ciKlass.cpp line 233: > 231: jint ciKlass::misc_flags() { > 232: assert(is_loaded(), "not loaded"); > 233: GUARDED_VM_ENTRY( To Compiler folks: I don't think the VM_ENTRY is necessary, but if it is, then we should consider entering VM mode once and caching/memoizing these immutable flag values in the ciKlass. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1737286933