On Fri, 30 Aug 2024 13:45:16 GMT, Yudi Zheng <yzh...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add in graal flags and a comment. > > src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 274: > >> 272: nonstatic_field(Klass, _bitmap, >> uintx) \ >> 273: nonstatic_field(Klass, _hash_slot, >> uint8_t) \ >> 274: nonstatic_field(Klass, _misc_flags._flags, >> u1) \ > > Can we export `_misc_flags` instead, similar to `_access_flags`? > > diff --git a/src/hotspot/share/jvmci/vmStructs_jvmci.cpp > b/src/hotspot/share/jvmci/vmStructs_jvmci.cpp > index 9d65268f0fe..6170647186c 100644 > --- a/src/hotspot/share/jvmci/vmStructs_jvmci.cpp > +++ b/src/hotspot/share/jvmci/vmStructs_jvmci.cpp > @@ -268,10 +268,10 @@ > nonstatic_field(Klass, _java_mirror, > OopHandle) \ > nonstatic_field(Klass, _modifier_flags, > jint) \ > nonstatic_field(Klass, _access_flags, > AccessFlags) \ > + nonstatic_field(Klass, _misc_flags, > KlassFlags) \ > nonstatic_field(Klass, _class_loader_data, > ClassLoaderData*) \ > nonstatic_field(Klass, _bitmap, > uintx) \ > nonstatic_field(Klass, _hash_slot, > uint8_t) \ > - nonstatic_field(Klass, _misc_flags._flags, > u1) \ > > \ > nonstatic_field(LocalVariableTableElement, start_bci, > u2) \ > nonstatic_field(LocalVariableTableElement, length, > u2) \ > diff --git > a/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java > > b/src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.jav... I don't think the JVMCI knows about the type KlassFlags - I used the same code that I used for InstanceKlass::_misc_flags._flags (see above this). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1738754099
