On Thu, 29 Aug 2024 18:50:42 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Move JVM implementation access flags that are not specified by the classfile
>> format into Klass so we can shrink AccessFlags to u2 in a future change.
>>
>> Tested with tier1-7.
>>
>> NOTE: there are arm, ppc and s390 changes to this that are just a guess.
>> Also, graal changes.
>
> Coleen Phillimore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Add in graal flags and a comment.
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java
line 378:
> 376: HotSpotVMConfig config = config();
> 377: int miscFlags = UNSAFE.getByte(getKlassPointer() +
> config.klassMiscFlagsOffset);
> 378: return (miscFlags & config().jvmAccHasFinalizer) != 0;
Suggestion:
return (miscFlags & config.jvmAccHasFinalizer) != 0;
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java
line 1117:
> 1115: HotSpotVMConfig config = config();
> 1116: int miscFlags = UNSAFE.getByte(getKlassPointer() +
> config.klassMiscFlagsOffset);
> 1117: return (miscFlags & config().jvmAccIsCloneableFast) != 0;
Suggestion:
return (miscFlags & config.jvmAccIsCloneableFast) != 0;
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java
line 1118:
> 1116: int miscFlags = UNSAFE.getByte(getKlassPointer() +
> config.klassMiscFlagsOffset);
> 1117: return (miscFlags & config().jvmAccIsCloneableFast) != 0;
> 1118: }
Maybe introduce getMiscFlags() helper like existing getAccessFlags()?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1737327588
PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1737331700
PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1737330084
