On Thu, 5 Mar 2026 16:28:34 GMT, Sean Mullan <[email protected]> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test code cleanup
>
> src/java.base/share/classes/sun/security/ssl/X509KeyManagerCertChecking.java
> line 515:
>
>> 513: } else {
>> 514: // Check the signature algorithm of the certificate
>> itself.
>> 515: // Look for the "withRSA" in "SHA1withRSA", etc.
>
> Can you add a comment for the ECDSA sigalg case showing that it doesn't end
> with EC.
Good idea, I suspect that comment was the reason I replaced it with `endsWith`
in the first place.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30064#discussion_r2891135082
