On Thu, 5 Mar 2026 14:29:16 GMT, Artur Barashev <[email protected]> wrote:
>> Regression introduced in >> [JDK-8359956](https://bugs.openjdk.org/browse/JDK-8359956). I don't >> recollect why, but I replaced `sigAlgName.contains(pattern)` with >> `sigAlgName.endsWith(pattern)` in the original code being re-worked. > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Test code cleanup src/java.base/share/classes/sun/security/ssl/X509KeyManagerCertChecking.java line 515: > 513: } else { > 514: // Check the signature algorithm of the certificate > itself. > 515: // Look for the "withRSA" in "SHA1withRSA", etc. Can you add a comment for the ECDSA sigalg case showing that it doesn't end with EC. test/jdk/sun/security/ssl/X509KeyManager/SelfSignedCertKeyType.java line 47: > 45: * java.base/sun.security.util > 46: * @library /test/lib > 47: * @run main/othervm SelfSignedCertKeyType SunX509 May not need othervm? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30064#discussion_r2891084654 PR Review Comment: https://git.openjdk.org/jdk/pull/30064#discussion_r2891095124
