On Thu, 5 Mar 2026 20:35:15 GMT, Sean Mullan <[email protected]> wrote:

>> Artur Barashev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Do not use othervm
>
> test/jdk/sun/security/ssl/X509KeyManager/SelfSignedCertKeyType.java line 71:
> 
>> 69:                 new String[]{KEY_TYPE}, null, null);
>> 70:         String engineClientAlias = km.chooseEngineClientAlias(
>> 71:                 new String[]{KEY_TYPE}, null, null);
> 
> How about also asserting that the returned alias is not null?

We assert it below. Actually `normalizeAlias` throws NPE before processing 
reaches `assertEquals`, but the test fails all the same.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30064#discussion_r2892248736

Reply via email to