On Thu, 5 Mar 2026 20:50:02 GMT, Artur Barashev <[email protected]> wrote:
>> test/jdk/sun/security/ssl/X509KeyManager/SelfSignedCertKeyType.java line 71:
>>
>>> 69: new String[]{KEY_TYPE}, null, null);
>>> 70: String engineClientAlias = km.chooseEngineClientAlias(
>>> 71: new String[]{KEY_TYPE}, null, null);
>>
>> How about also asserting that the returned alias is not null?
>
> We assert it below. Actually `normalizeAlias` throws NPE before processing
> reaches `assertEquals`, but the test fails all the same.
Ok , but I think the test should specifically check for null than relying on
NPE to be thrown.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30064#discussion_r2892267121
