On Thu, 5 Mar 2026 20:17:43 GMT, Artur Barashev <[email protected]> wrote:
>> Regression introduced in >> [JDK-8359956](https://bugs.openjdk.org/browse/JDK-8359956). I don't >> recollect why, but I replaced `sigAlgName.contains(pattern)` with >> `sigAlgName.endsWith(pattern)` in the original code being re-worked. > > Artur Barashev has updated the pull request incrementally with one additional > commit since the last revision: > > Do not use othervm test/jdk/sun/security/ssl/X509KeyManager/SelfSignedCertKeyType.java line 71: > 69: new String[]{KEY_TYPE}, null, null); > 70: String engineClientAlias = km.chooseEngineClientAlias( > 71: new String[]{KEY_TYPE}, null, null); How about also asserting that the returned alias is not null? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30064#discussion_r2892172065
