On Thu, 5 Mar 2026 00:32:27 GMT, Artur Barashev <[email protected]> wrote:

> Regression introduced in 
> [JDK-8359956](https://bugs.openjdk.org/browse/JDK-8359956). I don't recollect 
> why, but I replaced `sigAlgName.contains(pattern)` with 
> `sigAlgName.endsWith(pattern)` in the original code being re-worked.

lgtm, just 1 minor question

test/jdk/sun/security/ssl/X509KeyManager/SelfSignedCertKeyType.java line 114:

> 112:         kmf.init(ks, passphrase);
> 113: 
> 114:         return (X509KeyManager) kmf.getKeyManagers()[0];

Minor: why casting to `X509KeyManager` why not `X509ExtendedKeyManager`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/30064#pullrequestreview-3895503662
PR Review Comment: https://git.openjdk.org/jdk/pull/30064#discussion_r2889111566

Reply via email to