Re: [vpp-dev] build error in VPP master branch

2019-05-16 Thread Paul Vinciguerra
make wipe/wipe-release did not work for me. I needed to do an sudo apt-get remove vpp-ext-deps, then make build-ext-deps, which did not complete, but you can prod it along with cd /vpp/build/external sudo apt-get install ./vpp-ext-deps_19.08-4_amd64.deb -f Reading package lists... Done Buil

Re: [vpp-dev] device job voting?

2019-05-24 Thread Paul Vinciguerra
Hi Vratko, As long as CSIT uses "cli_inband" commands, I am against this. (This practice, by the way also short-circuits any/all flag day type efforts/proposals!) Traceback (most recent call last): File "/w/workspace/vpp-csit-verify-device-master-1n-skx/csit/resources/libraries/python/VPPUtil.p

[vpp-dev] Plugin Versions

2019-05-24 Thread Paul Vinciguerra
Is there any reason for having plugin versions that are distinct from their API versions? If not, is there any objection to having api's such as abf_plugin_get_version_reply return the semver[1] of the api? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply O

Re: [vpp-dev] Plugin Versions

2019-05-25 Thread Paul Vinciguerra
Hi Damian, That's what I initially thought as well.  The semver doc says: > > For this system to work, you first need to declare a public API. This may > consist of documentation or be enforced by the code itself. Regardless, it > is important that this API be  clear and precise. Once you identi

Re: [vpp-dev] Plugin Versions

2019-05-25 Thread Paul Vinciguerra
I or not, therefore incrementing the major, minor, or patch version. That seems to me to make the need for the plugin version to be redundant. Yes? On Sat, May 25, 2019 at 8:03 AM Damjan Marion via Lists.Fd.Io wrote: > > > On 25 May 2019, at 13:43, Paul Vinciguerra > wrote: > > Hi

[vpp-dev] test-debug in the CI

2019-06-25 Thread Paul Vinciguerra
I set up a job to view the results of debug images. For anyone who might be interested. https://gerrit.fd.io/r/#/c/20228/ logs: https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-beta-verify-master-ubuntu1804/7991 non-debug image EXTENDED_TESTS=1 can be seen here. https://gerrit.fd.io/r/#/c

Re: [vpp-dev] test-debug in the CI

2019-06-30 Thread Paul Vinciguerra
Thank you everyone.  The debug tests are running perfectly! -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#13404): https://lists.fd.io/g/vpp-dev/message/13404 Mute This Topic: https://lists.fd.io/mt/32206961/21656 Group Owner: vpp-dev+ow...@lists.fd

Re: [vpp-dev] sw interface information access

2019-07-09 Thread Paul Vinciguerra
Work is being done on version 3.0 of the interface api. See: https://gerrit.fd.io/r/#/c/18361/15/src/vnet/interface.api Reach out to the change owner and see if it can be added to the dump/details api. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (

Re: [vpp-dev] pg (missing) ethernet padding

2019-10-29 Thread Paul Vinciguerra
Hi Ben. Isn't it amazing how timing is everything. Would you believe this issue came up in discussion yesterday? I was suggesting the use of alternate interfaces, such as over tap/veth/af_packet over pg in tests. If the behavior is changed, it should probably be done in a backward compatible way

Re: [vpp-dev] Centos 8 and python scripts

2019-10-31 Thread Paul Vinciguerra
I am aware of the issue. I would suggest changing them all to python3. We can work through any issues that arise after the code passes the CI gates. Most of those shebangs are in place for developers using make test-shell, which could be evoking the script via 'python2 ' On Thu, Oct 31, 2019 at

[vpp-dev] per-node tracing

2019-10-31 Thread Paul Vinciguerra
Is there some simple way to identify the nodes that are supported under trace add? trace add: node 'ethernet-input' doesn't support per-node tracing. There may be another way to initiate trace on this node. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply On

Re: [vpp-dev] Centos 8 and python scripts

2019-10-31 Thread Paul Vinciguerra
31/10/19 11:09, Paul Vinciguerra wrote: > > I am aware of the issue. I would suggest changing them all to python3. > > We can work through any issues that arise after the code passes the CI > > gates. Most of those shebangs are in place for developers using make > > test-s

[vpp-dev] "ip virtual" command

2019-11-03 Thread Paul Vinciguerra
Would someone mind explaining the purpose of the "ip virtual" command?  It lives in vpe_cli.c, but I would have expected an ip command to be under vnet. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14476): https://lists.fd.io/g/vpp-dev/message/14

Re: [vpp-dev] API and plugins

2019-11-08 Thread Paul Vinciguerra
You can look up the msg_id against the plugin registration. No? I was looking at this to squash the papi log messages for when a plugin is not loaded. DBGvpp# show api plugin Plugin API message ID ranges... Name First-ID Last-ID abf_fc925b52

[vpp-dev] vpp-checkstyle-verify-master

2019-11-10 Thread Paul Vinciguerra
Can we update vpp-checkstyle-verify-master so that it actually calls make checkstyle, like it does for make test-checkstyle? The fact that the make target and the CI job configuration are different is causing some instability. https://jenkins.fd.io/job/vpp-checkstyle-verify-master/configure -=-=

Re: [vpp-dev] vpp-checkstyle-verify-master

2019-11-11 Thread Paul Vinciguerra
Thank you! On Mon, Nov 11, 2019 at 11:39 AM Dave Wallace wrote: > Paul, > > Please review https://gerrit.fd.io/r/c/ci-management/+/23364 > > ci-management patches require a non-author code review before merging. > > Thanks, > -daw- > > On 11/10/2019 11:24 AM, Paul

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Paul Vinciguerra
Can you leave it? The change in the makefile was backed out. Can we work on automating new containers when the makefile is updated? On Wed, Nov 13, 2019 at 8:58 AM Dave Wallace wrote: > Dave, > > My bad. I had Vanessa merge a patch to ci-management [0] which I tested > locally, but forgot that

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Paul Vinciguerra
How do people feel about managing the CI where possible via the Makefile by testing for JENKINS_URL? On Wed, Nov 13, 2019 at 10:11 AM Dave Wallace wrote: > Status update: > > Florin fixed 'make checkstyle' with [1] (Thanks Florin! :) > > Ed Kern has added 'make install-dep' to the checkstyle ve

Re: [vpp-dev] Requirements for DPDK pmd/feature testing in CSIT vpp-device-test jobs

2019-11-18 Thread Paul Vinciguerra
Hi Dave. Where does the vpp-device-test live? On Mon, Nov 18, 2019 at 11:13 AM Dave Wallace wrote: > Folks, > > Per the topic in last week's monthly VPP community meeting, the topic of > DPDK pmd/feature testing in the CSIT devicetest job was discussed in the > most recent CSIT community meetin

Re: [vpp-dev] Requirements for DPDK pmd/feature testing in CSIT vpp-device-test jobs

2019-11-19 Thread Paul Vinciguerra
f not, the +2 is removed. The existing csit job could be non-voting (so the csit folks could have a heads up) in the first phase, and voting in pre-commit-phase. Paul On Mon, Nov 18, 2019 at 12:18 PM Paul Vinciguerra via Lists.Fd.Io wrote: > Hi Dave. > > Where does the vpp-device-tes

[vpp-dev] Requesting feedback on a change.

2019-11-20 Thread Paul Vinciguerra
I introduced a change [0] that passes the CI gate, but it does so, because it it not actually tested by the CI.  ;P 1. For it to be tested properly, I need to reduce the number of cpu's exposed to vpp, and that requires running with elevated privileges [CAP_SYS_NICE] from what I can tell. We di

[vpp-dev] Change to Gerrit

2019-11-20 Thread Paul Vinciguerra
How would the group feel about implementing something like [0], so that changes to the commit message don't trigger rebuilds? To enforce the commit message structure, we could skip the jobs and set verify label after the codestyle checks if no files were changed. Maybe others don't care, but I d

Re: [vpp-dev] Change to Gerrit

2019-11-20 Thread Paul Vinciguerra
1... > > > --a > > On 20 Nov 2019, at 19:32, Paul Vinciguerra > wrote: > > How would the group feel about implementing something like [0], so that > changes to the commit message don't trigger rebuilds? > > To enforce the commit message structure, we could skip

[vpp-dev] CI Jobs being marked as unstable.

2019-11-20 Thread Paul Vinciguerra
Can someone please review https://gerrit.fd.io/r/c/vpp/+/23574 The containers may also need to have make install-dep run.  I'm not sure on how they are configured. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14652): https://lists.fd.io/g/vpp-de

Re: [vpp-dev] vpp19.08 ipsec vpp_papi

2019-11-24 Thread Paul Vinciguerra
That output is not random. It is the hex of your string. 2b7e -> *32 62 37 65* On Sun, Nov 24, 2019 at 8:06 AM Terry wrote: > Dear VPP experts, > > I'm trying to configure ipsec with python API in vpp19.08. > My configurations are as follows: > > reply = vpp.api.ipsec_tunnel_if_add_del(is_a

[vpp-dev] request review

2019-11-27 Thread Paul Vinciguerra
Can I nudge someone here to please review: https://gerrit.fd.io/r/c/vpp/+/23490 https://gerrit.fd.io/r/c/vpp/+/23521 They were added some 10 days ago to help Sunitha along with her failing job. https://gerrit.fd.io/r/c/vpp/+/23417 Latest logs here: https://logs.fd.io/production/vex-yul-rot-jenkin

Re: [vpp-dev] Patch validation seems to be broken: api-crc job, 'no module named ply...'

2019-12-02 Thread Paul Vinciguerra
How can we make this process more transparent? I saw this issue on Friday. I searched all the repo's for recently merged changes, but found nothing. Is there somewhere else to look that I'm not aware of? On Mon, Dec 2, 2019 at 8:25 AM Jerome Tollet via Lists.Fd.Io wrote: > Hi Dave, > > I ju

[vpp-dev] Using hoststack instead of tap

2019-12-02 Thread Paul Vinciguerra
There was a brief discussion on the community call about using hoststack as an alternative to running tests as a privileged user for a tap interface. Is there any documentation on this, or is there a representative test case I can reference? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages s

Re: [vpp-dev] merge jobs failing..

2019-12-17 Thread Paul Vinciguerra
Fixed: https://gerrit.fd.io/r/c/vpp/+/24041 On Tue, Dec 17, 2019 at 7:00 PM Ed Kern via Lists.Fd.Io wrote: > > Hey benoit, > > Happened to notice (because I was watching the queue anyway since santa > damjan did a bunch of merges) that ubuntu test/merges started failing > after > https://gerrit.

[vpp-dev] arm hardware recommendation

2019-12-21 Thread Paul Vinciguerra
I'm looking for something that I can run tests on an arm platform in a reasonable timeframe. Any suggestions? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14942): https://lists.fd.io/g/vpp-dev/message/14942 Mute This Topic: https://lists.fd.io/m

Re: [vpp-dev] arm hardware recommendation

2019-12-22 Thread Paul Vinciguerra
ycomb/ On Sun, Dec 22, 2019 at 3:06 PM Damjan Marion wrote: > > > > On 22 Dec 2019, at 01:02, Paul Vinciguerra > wrote: > > > > I'm looking for something that I can run tests on an arm platform in a > reasonable timeframe. > > > > Any suggestions

Re: [vpp-dev] arm hardware recommendation

2019-12-22 Thread Paul Vinciguerra
Have you used it? How long does it take to build vpp and run the tests? On Sun, Dec 22, 2019 at 7:23 PM Jim Thompson wrote: > https://shop.solid-run.com/product/SRM8040S00D16GE008S00CH/ > > On Dec 22, 2019, at 2:50 PM, Paul Vinciguerra > wrote: > >  > Hi Damian, > &g

[vpp-dev] Discrepancies between CI jobs and s5ci

2019-12-27 Thread Paul Vinciguerra
I have been trying to figure out why I've been seeing different results between the CI jobs and s5ci jobs. What I've discovered is that the CI jobs are running as the root user in a fully privileged container, where s5ci runs unprivileged. I am aware that there has been a long-standing desire for

Re: [vpp-dev] Discrepancies between CI jobs and s5ci

2019-12-27 Thread Paul Vinciguerra
at the recently added tap tests will > make it fail: http://s5ci.myvpp.net/jobs/vpp-periodic-make-verify/ is > only failures as of 12:25 UTC 24th December. > > So, what is the direction the community wants to go ? > > --a > > On 27 Dec 2019, at 17:22, Paul Vinciguerra > wrote

Re: [vpp-dev] Discrepancies between CI jobs and s5ci

2019-12-28 Thread Paul Vinciguerra
=== On Sat, Dec 28, 2019 at 7:44 AM Dave Barach (dbarach) wrote: > My $0.02: I would like “make test[-debug]” to work without privileges. > > > > Thanks... Dave > > > > *From:* vpp-dev@lists.fd.io *On Behalf Of *Andr

Re: [vpp-dev] How to show all configurations and save configuration at runtime?

2019-12-30 Thread Paul Vinciguerra
See if the log option [0] helps you. unix { nodaemon log /var/log/vpp/vpp.log full-coredump cli-listen /run/vpp/cli.sock gid vpp} [0] https://fd.io/docs/vpp/master/gettingstarted/users/configuring/startup.html#log-filename On Sun, Dec 29, 2019 at 10:01 PM Xiaopeng Bai wrote: > Hi, guy

Re: [vpp-dev] Discrepancies between CI jobs and s5ci

2020-01-02 Thread Paul Vinciguerra
This has gone a little off the original topic. Do we want to run the CI tests as an unprivileged user (something as simple as su to a vpp user) or just let the community be aware that the CI test results are different than when run locally? But as to Damjan's and Blaji's comments, I agree.  I pe

Re: [vpp-dev] python api over tcp?

2020-01-09 Thread Paul Vinciguerra
Is there any objection to adding a tls listener and an instance to the stats client to vpp_papi? > On Jan 9, 2020, at 6:45 AM, Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES > at Cisco) via Lists.Fd.Io wrote: > >  > CSIT uses VPP API via socket (tunneled over SSH) for most interactions. > >

Re: [vpp-dev] install-dep fails in RedHat (RHEL)

2020-01-09 Thread Paul Vinciguerra
Can you submit a patch to the Makefile that applies your fix? On Thu, Jan 9, 2020 at 4:48 AM wrote: > Thanks for your response Benoit. > After installing epel repo, it works fine. > > Regards, > Vijayalakshmi > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Re

Re: [vpp-dev] python api over tcp?

2020-01-09 Thread Paul Vinciguerra
> > > On 9 Jan 2020, at 16:50, Paul Vinciguerra > wrote: > >  > Is there any objection to adding a tls listener and an instance to the > stats client to vpp_papi? > > > Use grpc as transport? > > Cheers, > Ole > > > On Jan 9, 2020, at 6:45 AM, Vra

Re: [vpp-dev] python api over tcp?

2020-01-09 Thread Paul Vinciguerra
On 9 Jan 2020, at 19:10, Paul Vinciguerra >>> wrote: >>> >>  >> Sounds like a little scope creep going on there. >> If you provide protobuf3 encoded api messages to/from vpp, I'll add a grpc >> listener option to vpp_papi, in the interim, I'd b

Re: [vpp-dev] python api over tcp?

2020-01-10 Thread Paul Vinciguerra
Hi Ole. Where can we find the Telegraf plugin? On Thu, Jan 9, 2020 at 5:44 AM Ole Troan wrote: > Christian, > > >> For exporting data out of the stats segment, I believe there is already > quite a few solutions. > >> There's the (naive) prometheus example in the repo, vpp_get_stats, > there is

Re: [vpp-dev] #vnet Any command to individually enable and disable IP forwarding per interface level

2020-01-22 Thread Paul Vinciguerra
Hi Neale, Can you not also do: comment { ingress direction } set interface feature loop0 ip4-lookup arc ip4-unicast disable comment { egress direction } set interface feature loop0 arp-reply arc arp disable On Wed, Jan 22, 2020 at 12:16 PM Neale Ranns via Lists.Fd.Io wrote: > > > hi, > > >

Re: [vpp-dev] route lookup api

2020-02-18 Thread Paul Vinciguerra
Those don't seem to be exposed via the api dump/details. The pattern that is commonly used in the test framework is to call vapi.cli_inline(cmd="show ip fib 1.2.3.4/24") On Tue, Feb 18, 2020 at 5:53 PM Christian Hopps wrote: > In the CLI there's an option to lookup route for a given IP. Is ther

Re: [vpp-dev] VPP configuration getting erased on VPP restart

2020-02-28 Thread Paul Vinciguerra
Hi Chinmaya. Follow Dave's input. I'm obsessive over typo's/transcription errors, so I've done it like this in the past: Edit your startup.conf to include: unix { nodaemon *log /etc/vpp/startup-conf* full-coredump cli-listen /run/vpp/cli.sock gid vpp } start vpp and configure your sys

Re: [vpp-dev] vpp project committers: formal vote to add Matt Smith as a vpp committer

2020-03-02 Thread Paul Vinciguerra
+1 > On Mar 2, 2020, at 9:20 AM, d...@barachs.net wrote: > >  > VPP committers, please vote +1, 0, -1 on adding Matt Smith > (mgsm...@netgate.com) as a vpp project committer. > Matt has contributed O(100) merged patches, and he recently contributed the > entire vrrp plugin. See https://gerrit.

Re: [vpp-dev] how to catch packets on a specific TCP port

2020-03-05 Thread Paul Vinciguerra
Have you looked at the http_static plugin? > On Mar 5, 2020, at 5:33 AM, Satya Murthy wrote: > > Hi, > > We are looking for a way to get all the packets on a particular TCP port to > reach our plugin. > For UDP ports, we could see that udp_register_dst_port() can be used to get > packets on

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-12 Thread Paul Vinciguerra
Yes. Has been for a few days. On Thu, Mar 12, 2020 at 9:25 AM Ray Kinsella wrote: > Anyone else noticing seeming spurious failures related to the VRRP > plugin's unit tests. > Some examples from un-related commits. > > Ray K > > nat: timed out session scavenging upgrade ( > https://gerrit.fd.io/

Re: [vpp-dev] VRRP Unit Tests failing on Master Ubuntu

2020-03-13 Thread Paul Vinciguerra
Hi Dave, Please don't add broken tests to extended tests. See https://gerrit.fd.io/r/c/vpp/+/24567/12/test/test_bfd.py Thanks! On Fri, Mar 13, 2020 at 1:33 PM Dave Wallace wrote: > Matt, > > I will keep an eye on this gerrit and merge it once the verify jobs have > completed. > If there are o

Re: [vpp-dev] Unit Test Results in Random directories

2020-03-17 Thread Paul Vinciguerra
I'm ok with a change, but are you thinking about setting the tempdir to a constant, or do you want to remove the unix { runtime-dir } option from the startup? On Tue, Mar 17, 2020 at 1:04 PM Klement Sekera via Lists.Fd.Io wrote: > Hi Neale, > > When originally designing this, I opted in for `mkt

Re: [vpp-dev] vpp_papi not updated

2020-03-27 Thread Paul Vinciguerra
try 'test-wipe-papi'. You may need: https://gerrit.fd.io/r/c/vpp/+/26177 On Fri, Mar 27, 2020 at 6:26 PM Christian Hopps wrote: > [on 19.08] > > I'm seeing something odd building. When I "make build" after changing > something in "src/vpp-api/python/vpp_papi/*.py" it does not get reinstalled >

Re: [vpp-dev] vpp_papi not updated

2020-03-27 Thread Paul Vinciguerra
t's not setting up any dependencies? > > Thanks, > Chris. > > > On Mar 27, 2020, at 6:30 PM, Paul Vinciguerra < > pvi...@vinciconsulting.com> wrote: > > > > try 'test-wipe-papi'. > > You may need: > > > > https://gerrit.fd.io/r/c/vp

Re: [vpp-dev] vpp_papi not updated

2020-03-27 Thread Paul Vinciguerra
I'm not running unit > tests, I'm actually just using the python API in another application that > controls/monitors VPP. > > Thanks, > Chris. > > > On Mar 27, 2020, at 6:45 PM, Paul Vinciguerra < > pvi...@vinciconsulting.com> wrote: > > > > F

Re: [vpp-dev] VPP nat ipfix logging problem, need to use thread-specific vlib_main_t?

2020-04-05 Thread Paul Vinciguerra
How can we test scenarios like this? 'set interface rx-placement' doesn't support pg interfaces. DBGvpp# set interface rx-placement TenGigabitEthernet5/0/0 worker 2 DBGvpp# set interface rx-placement pg0 worker 2 set interface rx-placement: not found DBGvpp# Is there another command to bind a pg

Re: [vpp-dev] VPP nat ipfix logging problem, need to use thread-specific vlib_main_t?

2020-04-06 Thread Paul Vinciguerra
Thanks Dave, Neale. This is great information. On Mon, Apr 6, 2020 at 6:14 AM Neale Ranns (nranns) wrote: > > > In the test harness you can inject onto a given worker, e.g. see > IpsecTun6HandoffTests. > > > > /neale > > > > *From: * on behalf of Paul Vincig

Re: [vpp-dev] Jobs are failing due to inspect.py

2020-04-06 Thread Paul Vinciguerra
Andrew submitted a changeset that backs out the updated Sphinx package. I am building the target 'test-doc' to try to learn the root cause. On Mon, Apr 6, 2020 at 11:03 AM steven luong via lists.fd.io wrote: > Folks, > > > > It looks like jobs for all branches, 19.08, 20.01, and master, are fai

Re: [vpp-dev] Jobs are failing due to inspect.py

2020-04-06 Thread Paul Vinciguerra
: The full traceback has been saved in /tmp/sphinx-err-o2xo4j0j.log I will gladly look into it. Paul On Mon, Apr 6, 2020 at 11:15 AM Paul Vinciguerra via lists.fd.io wrote: > Andrew submitted a changeset that backs out the updated Sphinx package. I > am building the target 'test-doc

Re: [vpp-dev] Jobs are failing due to inspect.py

2020-04-06 Thread Paul Vinciguerra
enkins.fd.io/job/vpp-make-test-docs-verify-master/19049/console>* > > > > 20.01 > > https://jenkins.fd.io/job/vpp-make-test-docs-verify-2001/61/console > > > > Steven > > > > *From: *Paul Vinciguerra > *Date: *Monday, April 6, 2020 at 8:35 AM

[vpp-dev] Centos-7 jobs failing in the CI

2020-04-11 Thread Paul Vinciguerra
Jobs are consistently failing in the CI now. make[6]: warning: Clock skew detected. Your build may be incomplete. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16048): https://lists.fd.io/g/vpp-dev/message/16048 Mute This Topic: https://lists.fd

Re: [vpp-dev] Issues with counters in statistics segment

2020-04-11 Thread Paul Vinciguerra
Hi Bin, 'show stats seg' shows the layout of the data in the stats segment. ' /err/af-packet-input/partial packet ' is at index number 211. I think you are looking for: DBGvpp# create loop interface loop0 DBGvpp# set interface state loop0 up DBGvpp# set interface lldp loop0 DBGvpp# show node coun

Re: [vpp-dev] vpp project committer nomination: Benoit Ganne

2020-04-21 Thread Paul Vinciguerra
+1 > On Apr 21, 2020, at 7:45 AM, Dave Barach via lists.fd.io > wrote: > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16128): https://lists.fd.io/g/vpp-dev/message/16128 Mute This Topic: https://lists.fd.io/mt/73170252/21656 Group Owner: vpp-d

Re: [vpp-dev] ACL question

2020-04-28 Thread Paul Vinciguerra
See: src/plugins/acl/test/test_acl_plugin.py On Tue, Apr 28, 2020 at 7:19 PM Govindarajan Mohandoss < govindarajan.mohand...@arm.com> wrote: > Sure Andrew. Is there a unit test case for ACL plugin ? > > > > *From:* Andrew 👽 Yourtchenko > *Sent:* Tuesday, April 28, 2020 4:57 PM > *To:* Govindaraj

Re: [vpp-dev] VPP Multi-versioning changes on x86

2020-04-29 Thread Paul Vinciguerra
Hi Damjan, Code was recently added for vpp to specify the variant to use. Is there a minimum hardware spec for the CI tests, and what are your thoughts on testing the variants? Paul On Wed, Apr 29, 2020 at 12:05 PM Damjan Marion via lists.fd.io wrote: > > As you probably know, VPP build system

[vpp-dev] api_format.c

2020-05-01 Thread Paul Vinciguerra
I've run into an api where the api was changed and the SCRIPT: output wasn't updated to match. I'd like to clean it up.  What is the best way to verify that the api_format code is correct? Is a self.vapi.cli("binary-api foo") in a python unit test sufficient? -=-=-=-=-=-=-=-=-=-=-=- Links: You r

[vpp-dev] 11th hour changes and code reviews

2020-05-04 Thread Paul Vinciguerra
I was -2'd this morning for submitting a change with a "blast radius" this close to api freeze [0].  It was suggested that it should be discussed on the dev list and that multiple parties outside of vpp should have to +1 it.  I am glad to start the conversation. My change is dependent on anothe

[vpp-dev] Resources for learning about VOM

2020-05-04 Thread Paul Vinciguerra
Does anything exist beyond the description on the wiki? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16235): https://lists.fd.io/g/vpp-dev/message/16235 Mute This Topic: https://lists.fd.io/mt/73983633/21656 Group Owner: vpp-dev+ow...@lists.fd.io

Re: (Q about fixing endianness bugs in handlers) Re: [vpp-dev] Proposal for VPP binary API stability

2020-05-15 Thread Paul Vinciguerra
I chimed in initially, because admittedly, I am usually the one breaking the api, (with Vratko telling me to stop breaking CSIT ;/ ) and I learned a lot in the process. 1. The thing we don't have today that would have caught these endian issues are api tests. a. Send in a create and verify all t

[vpp-dev] vpp-merge-master-centos7 jobs are broken

2020-05-15 Thread Paul Vinciguerra
I'm not sure who this should go to, nor the impact, so I'm posting it here. vpp-merge-master-centos7 is failing due to libmemif and [ -Wstringop-overflow=] see [0]. [0] https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-merge-master-centos7/9496/console.log.gz ( https://logs.fd.io/produc

Re: [vpp-dev] Fix in set_ipfix_exporter_command_fn() to avoid segmentation fault crash

2020-05-28 Thread Paul Vinciguerra
A few weeks back, I became aware of the following issue with the LISP tests: /vpp/build-root/install-vpp_debug-native/vpp/bin/vpp[63989]: vnet_lisp_add_del_locator_set:2140: Can't delete a locator that supports a mapping! /vpp/build-root/install-vpp_debug-native/vpp/bin/vpp[63989]: received signal

Re: [vpp-dev] generic TCP MSS clamping

2020-05-31 Thread Paul Vinciguerra
Yes, please do. My changeset only freshens the api code to take advantage of the refactorings that have been put in place since that code was last submitted and fix the tests to work properly under python3 in anticipation of your changes. Paul On Sun, May 31, 2020 at 5:23 AM Miklós Tirpák wrote

Re: [vpp-dev] Building with fresh Ubuntu Focal

2020-06-01 Thread Paul Vinciguerra
Hi Keith, Yes. The build assumes that vppapigen runs in the global python environment such as if in a fresh container. It is the same issue we have with generating vpp papi packages. It installs into the global environment and people have no option to pip install it without downloading the sour

Re: [vpp-dev] test/requirements-3.txt snnoyance

2020-06-23 Thread Paul Vinciguerra
Hi Damjan, My personal solution is 'git-review -X 21208', 'make wipe-test test. HTH, On Tue, Jun 23, 2020 at 12:27 PM Damjan Marion via lists.fd.io wrote: > Folks, > > Every time I run “make test”, i need to deal with modifications in > test/requirements-3.txt > > Even worse, if I do “git check

Re: [vpp-dev] regarding cross compiling

2018-12-19 Thread Paul Vinciguerra
Hi Andrew. As a non-cisco observer to group, I respectfully disagree. I'm sure the old code is still available in the repo for your use, should you wish to use it. You however took the position that the community here needs to take their resources and use them to maintain a solution that you fav

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Paul Vinciguerra
Up until two days ago, make wipe did not clean out .api.json files. It had to be done by hand. https://gerrit.fd.io/r/#/c/16405/ My fix is more likely a workaround that gets me working and I am ok reverting if necessary. I can always cherry pick it with git review -x. I think Neale is right and

Re: [vpp-dev] build errors on CenOS 7.5

2018-12-20 Thread Paul Vinciguerra
t; I think we need to VPP API compiler to generate the necessary dependencies > (e.g. as the usual .d file) for the imports it sees. This way we can setup > the necessary dependencies in the makefile. > > > > /neale > > > > > > *De : *Paul Vinciguerra > *Dat

Re: [vpp-dev] VPP Failing (all?) Verify Jobs

2018-12-28 Thread Paul Vinciguerra
Hi Jon, I opened a ticket (#66166) with the helpdesk on 12/25. "Starting Dec. 14, 2018 through Jan. 1, 2019 the Linux Foundation will be operating with reduced staff in observance of our office closure. Responses to inbound support requests will be delayed, or otherwise addressed after Jan. 2, 20

Re: [vpp-dev] VPP Release 19.01 (F0): 2 weeks notice reminder

2019-01-01 Thread Paul Vinciguerra
Happy New Year! Can I ask for volunteers to test out https://gerrit.fd.io/r/#/c/16555/ ? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11811): https://lists.fd.io/g/vpp-dev/message/11811 Mute This Topic: https://lists.fd.io/mt/28859159/21656 Group

[vpp-dev] Python Tests

2019-01-03 Thread Paul Vinciguerra
I am working on a change to cleanup some anti-patterns in the test framework code, but the scope is significantly larger.   https://gerrit.fd.io/r/#/c/16642/ Specifically, I'm referring to the use of:   except: and   raise Exception(...) This is not in any way a dig against any of the contributo

Re: [vpp-dev] :: GRE tunnel dropping MPLS packets

2019-01-07 Thread Paul Vinciguerra
Hi Omer. Would you be willing to help us out and provide a unit test that simulates this failure? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11859): https://lists.fd.io/g/vpp-dev/message/11859 Mute This Topic: https://lists.fd.io/mt/28966281/2

[vpp-dev] VIRL jobs in CI gate

2019-01-13 Thread Paul Vinciguerra
What do people think about changing the CI gate verify job to only run VIRL jobs for change-sets that touch the src/ folder?  It seems like the current process uses more resources than needed. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11904):

Re: [vpp-dev] Issues running vpp #vpp

2019-01-14 Thread Paul Vinciguerra
You probably need to either run VPP as root or specify an alternate file location that your user can write to in your config.  cli-listen /run/vpp/cli.sock -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11913): https://lists.fd.io/g/vpp-dev/message

Re: [vpp-dev] PEP8 expert needed

2019-01-29 Thread Paul Vinciguerra
They started popping up because a new version was released earlier today. *https://pypi.org/project/pycodestyle/ * *Changelog * 2.5.0 (2019-01-29) New checks: * E117: Over-indented code blocks * W505: Maximum doc-string length only when configured with –max-doc-length -=-=-=-=-=-=-=-=-=-=-=- Link

Re: [vpp-dev] opensuse expert needed

2019-01-30 Thread Paul Vinciguerra
I would agree that the error seems to indicate that the build-host has insufficient /tmp space. There is no doubt, that the build system, like the test system, could use some love. What is your feeling on moving the CI logic out of the makefile? Do you care about the error, or do you care about

Re: [vpp-dev] VPP delete map-reply from cisco router

2019-01-30 Thread Paul Vinciguerra
Hi Florin, Is lisp control message tracing needed, or is it better to use the new wireshark extensions? On Wed, Jan 30, 2019 at 1:23 PM Florin Coras wrote: > Yosvany, > > The trace you provided shows that the packet was processed okay and then > dropped. Do you see any lisp errors if you do “sh

Re: [vpp-dev] VPP send map-register with R=0 on LISP

2019-01-30 Thread Paul Vinciguerra
Are you testing a shared-mode or parallel-mode topology? On Wed, Jan 30, 2019 at 7:11 PM Florin Coras wrote: > As per previous email, please check for any errors reported by lisp-cp in > cli and syslog. > > Florin > > On Jan 30, 2019, at 9:50 AM, Yosvany wrote: > > Yes was solved, but we have m

Re: [vpp-dev] VPP 19.01 release is out!

2019-01-31 Thread Paul Vinciguerra
now available. > > > > Release artificats can be found on both Nexus and Packagecloud. > > > > Thanks to all the contributors and committers, and also special > > thanks from me who helped to make this adventurous ride a little > smoother. > > > > I would

[vpp-dev] gcc versions

2019-02-01 Thread Paul Vinciguerra
What versions of gcc are supported for building vpp? -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12134): https://lists.fd.io/g/vpp-dev/message/12134 Mute This Topic: https://lists.fd.io/mt/29624653/21656 Group Owner: vpp-dev+ow...@lists.fd.io Uns

Re: [EXT] [vpp-dev] RFC: buffer manager rework

2019-02-04 Thread Paul Vinciguerra
+1 VPP without DPDK. -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12164): https://lists.fd.io/g/vpp-dev/message/12164 Mute This Topic: https://lists.fd.io/mt/29655016/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/

Re: [vpp-dev] [19.01] Multiple tests fail

2019-02-18 Thread Paul Vinciguerra
I just looked at those tests. Cherry-pick this change and test. https://gerrit.fd.io/r/#/c/17653/ On Mon, Feb 18, 2019 at 7:48 AM Damjan Marion via Lists.Fd.Io wrote: > > jvpp is in process of moving to separate fd.io project, so we are not > building jars anymore. > Those tests should be rem

Re: [vpp-dev] OpenSuse builds failing for stable/1901

2019-02-27 Thread Paul Vinciguerra
Can we confirm that they are truly osleap15? An osleap box reports correctly for me: docker run --shm-size=1024m -it opensuse/leap:leap-15 /bin/bash *ee4938c281e4:/ #* cat /etc/os-release NAME="openSUSE Leap" VERSION="15.0 Beta" ID="opensuse" ID_LIKE="suse" VERSION_ID="15.0" PRETTY_NAME="o

Re: [vpp-dev] OpenSuse builds failing for stable/1901

2019-02-27 Thread Paul Vinciguerra
/etc/os-release as you suggested, > and rechecked: https://gerrit.fd.io/r/#/c/17884/ > to see what happens :) > > Ed > > On Wed, Feb 27, 2019 at 12:48 PM Paul Vinciguerra < > pvi...@vinciconsulting.com> wrote: > >> Can we confirm that they are truly osleap15? >

Re: [vpp-dev] OpenSuse builds failing for stable/1901

2019-02-27 Thread Paul Vinciguerra
x27;ve pushed >> https://gerrit.fd.io/r/#/c/17916/ >> >> to cause the opensuse jobs to cat the /etc/os-release as you suggested, >> and rechecked: https://gerrit.fd.io/r/#/c/17884/ >> to see what happens :) >> >> Ed >> >> On Wed, Feb 27, 2019 at 12

Re: [vpp-dev] OpenSuse builds failing for stable/1901

2019-02-27 Thread Paul Vinciguerra
appears* to have fixed it: > > https://gerrit.fd.io/r/#/c/17884/ > > Ed > > On Wed, Feb 27, 2019 at 2:14 PM Paul Vinciguerra < > pvi...@vinciconsulting.com> wrote: > >> Ok. >> >> Let me know if I can do anything to help! >> >> On We

Re: [vpp-dev] Build failure question

2019-03-04 Thread Paul Vinciguerra
Is this a “must have” or a “nice to have” feature? I guess what I’m really asking is if this belongs in a CI job. Paul > On Mar 4, 2019, at 4:52 PM, Thomas F Herbert wrote: > > Damjan et. al. > > I get build failures when builging from a tarball outside of git tree on > 19.01 > > I docum

Re: [vpp-dev] Fragmentation and Reassembly #vnet

2019-03-13 Thread Paul Vinciguerra
Hi Sam, Would you be willing to create unittests for the scenarios you are testing? On Wed, Mar 13, 2019 at 1:00 PM Ole Troan wrote: > > I am setting MTU to 1500 and trying to test larger packets. (by enabling > reassembly feature on interfaces) > > It seems to work fine on regular interfaces.

Re: [vpp-dev] is sw_interface_dump api bug?

2019-03-14 Thread Paul Vinciguerra
4) sw_interface_dump return loop10's info instead of loop1 I tested without your patch, and sw_interface_dump returns both interfaces that match the filter of 'loop1'.              Name             Idx   State MTU (L3/IP4/IP6/MPLS)   Counter         Count      local0                           

Re: [vpp-dev] VPP plugin unit test framework

2019-03-27 Thread Paul Vinciguerra
Hi Satish. The existing framework works by providing a subclass of the python unittest.TestCase. It is extremely heavy and opinionated. I often find myself needing something lighter and writing my own tests from scratch. Could you please elaborate further on your specific needs? I may have cod

[vpp-dev] Centos CI jobs failing

2019-04-05 Thread Paul Vinciguerra
FYI. The centos CI jobs are failing.   This is due to centos updating the python34 packages with python36 which is breaking vppapigen. I am testing a fix in https://gerrit.fd.io/r/#/c/18709/ Paul -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#12

Re: [vpp-dev] VPP 19.04 centos7 RPM package dependency errors

2019-04-11 Thread Paul Vinciguerra
I looked at this a while back. The spec file doesn’t pick up the packages from the makefile. I can look at it in a few hours if you like. Let me know. > On Apr 11, 2019, at 6:25 PM, Thomas F Herbert wrote: > > Dave and Ed, > > The Makefile has dependencies that work. However, you will need e

Re: [vpp-dev] sw_interface_dump changes

2019-04-18 Thread Paul Vinciguerra
Hi Matt. If you look at https://gerrit.fd.io/r/#/c/18693/5/test/vpp_papi_provider.py, the field was set to default to ~0 for the python client. When I made the change, I chose to do it this way to make the api fall more in line with other calls such as l2_interface_efp_filter and sw_interface_rx_

  1   2   >