You can look up the msg_id against the plugin registration. No?
I was looking at this to squash the papi log messages for when a plugin is
not loaded.

DBGvpp# show api plugin
Plugin API message ID ranges...
Name                                               First-ID  Last-ID
abf_fc925b52                                            788      797
acl_c4123e02                                            798      835
arp_9bb2d862                                            836      845
avf_ac2e1d93                                           1213     1216
builtinurl_25045d63                                     846      847
cdp_994342d8                                            848      849
ct6_8c8159a0                                            850      851
dhcp6_ia_na_client_cp_b92e5285                          852      853
dhcp6_pd_client_cp_5b1cb936                             854      857
dhcp_9ad28d0a                                          1217     1245

On Fri, Nov 8, 2019 at 8:47 AM Vratko Polak -X (vrpolak - PANTHEON
TECHNOLOGIES at Cisco) via Lists.Fd.Io <vrpolak=cisco....@lists.fd.io>
wrote:

> Questions: If an API message handler is moved into a different plugin,
>
> does it constitute a (backward incompatible) API change?
>
> If yes, should we use similar checks and processes as for CRC changes?
>
>
>
> Example (not merged yet): sw_interface_ip6nd_ra_config
>
> is being moved from vnet [0] to plugins/ip6-nd [1].
>
>
>
> Discussion: While section 7 of RFC2544 [2] requires the tests
>
> to be run with all plugins enabled, CSIT tests are also aimed
>
> at detecting performance regressions in specific functions,
>
> which is less noisy when enabling minimal set of plugins needed.
>
> In order to keep equivalence between configurations
>
> of performance and functional tests,
>
> CSIT uses minimal plugin configurations when verifying API functionality.
>
> As ip6-nd is a new plugin introduced in 22819,
>
> CSIT functional tests are not enabling it,
>
> which results in the API message to become unrecognized [3] by the VPP
> process.
>
> The current CRC checks aggregate all messages (with CRCs)
>
> into a flat list, so the information on which plugin handles a message is
> lost.
>
> Should we (CSIT) change the checks to track also the implementing plugin
>
> (making 22819 fail the CRC job and triggering API upgrade process [4])?
>
>
>
> Note: The issue of changing plugin requirements
>
> was first encountered in a Change [5],
>
> which does not touch .api files,
>
> so even the proposed update of CRC job would not have detected it.
>
>
>
> Vratko.
>
>
>
> [0] https://gerrit.fd.io/r/c/vpp/+/22819/10/src/vnet/ip/ip.api#b253
>
> [1]
> https://gerrit.fd.io/r/c/vpp/+/22819/10/src/plugins/ip6-nd/ip6_nd.api#93
>
> [2] https://tools.ietf.org/html/rfc2544
>
> [3]
> https://logs.fd.io/production/vex-yul-rot-jenkins-1/vpp-csit-verify-device-master-1n-skx/4129/archives/log.html.gz#s1-s1-s1-s6-s1-t1-k2-k8-k13
>
> [4]
> https://github.com/FDio/csit/blob/f7d43390a6ce60284f54cad4e66b66d1ecd4a166/docs/automating_vpp_api_flag_day.rst
>
> [5] https://gerrit.fd.io/r/c/vpp/+/22980
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#14546): https://lists.fd.io/g/vpp-dev/message/14546
> Mute This Topic: https://lists.fd.io/mt/47762399/1594641
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [
> pvi...@vinciconsulting.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#14551): https://lists.fd.io/g/vpp-dev/message/14551
Mute This Topic: https://lists.fd.io/mt/47762399/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
  • ... Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io
    • ... Andrew Yourtchenko
      • ... Vratko Polak -X (vrpolak - PANTHEON TECHNOLOGIES at Cisco) via Lists.Fd.Io
        • ... Andrew Yourtchenko
          • ... Ole Troan
          • ... Dave Wallace
    • ... Paul Vinciguerra

Reply via email to