I was -2'd this morning for submitting a change with a "blast radius" this close to api freeze [0]. It was suggested that it should be discussed on the dev list and that multiple parties outside of vpp should have to +1 it. I am glad to start the conversation.
My change is dependent on another developer's change has been sitting waiting. for a response from csit-dev almost a week. I asked last week if it would be ok to refactor out the non-csit related code, but got no response. I refactored the dependent code out of the other change, but it is still outstanding. I agree that the change I submitted is a monster. Honestly, there are 2-5 git-friendly changes that could be refactored out of it. Its written and used by me, but it's not worth investing the time to make mergeable if there is no desire for it. I only submitted it at all because I had mentioned last week to someone that I had essentially stopped contributing and I was asked if I could be enticed to start re-submitting code. There is no intent on my part to subvert the release. Everyone complains about the tests. I was "asked" last year to clean up the tests. It's not that code hasn't been written to clean it up. The reality is that code becomes a monster when simple refactorings aren't merged. If you all tell me you want the changes, I'm glad to clean it up. If, in the meantime, someone wants to +2 Neale's change [2], that would be great! [0] https://gerrit.fd.io/r/c/vpp/+/26833 ( https://gerrit.fd.io/r/c/vpp/+/26833 ) [1] https://lists.fd.io/g/csit-dev/message/4009 ( https://lists.fd.io/g/csit-dev/message/4009 ) [2] https://gerrit.fd.io/r/c/vpp/+/26820/4
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16231): https://lists.fd.io/g/vpp-dev/message/16231 Mute This Topic: https://lists.fd.io/mt/73980355/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
