Speaking for myself only, I would prefer that we didn't introduce per platform changes. It would seem better to apply a single change that makes it through the CI gates.
Is it time for a (non-voting) Centos8 CI job? On Thu, Oct 31, 2019 at 12:06 PM Renato Botelho do Couto <ren...@netgate.com> wrote: > On 31/10/19 11:09, Paul Vinciguerra wrote: > > I am aware of the issue. I would suggest changing them all to python3. > > We can work through any issues that arise after the code passes the CI > > gates. Most of those shebangs are in place for developers using make > > test-shell, which could be evoking the script via 'python2 <foo.py>' > > Since I don't want to break other platforms my idea is to add sed call > to build/external/rpm/vpp-ext-deps.spec to replace shebang lines that > are affecting package build only if it's a CentOS 8. > > If you say it's acceptable I'll submit a patch. > > -- > Renato Botelho do Couto > Software Engineer > Netgate >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14424): https://lists.fd.io/g/vpp-dev/message/14424 Mute This Topic: https://lists.fd.io/mt/40145444/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
