I am working on a change to cleanup some anti-patterns in the test framework code, but the scope is significantly larger. https://gerrit.fd.io/r/#/c/16642/
Specifically, I'm referring to the use of: except: and raise Exception(...) This is not in any way a dig against any of the contributors. The pattern is recommended in the docs for people to follow. Does anyone have any suggestions as to how to best involve the original contributors without stalling progress? Is adding reviewers from git blame sufficient, or do the original contributors prefer to know earlier in the process? Here are some links if anyone is interested: https://julien.danjou.info/python-exceptions-guide/ https://hynek.me/articles/hasattr/
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11828): https://lists.fd.io/g/vpp-dev/message/11828 Mute This Topic: https://lists.fd.io/mt/28925838/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
