Up until two days ago, make wipe did not clean out .api.json files. It had
to be done by hand. https://gerrit.fd.io/r/#/c/16405/
My fix is more likely a workaround that gets me working and I am ok
reverting if necessary. I can always cherry pick it with git review -x.
I think Neale is right and my change masks another problem. My question is
this: What unit test can we write that expose the proper and improper
behaviors? Something in test_vapi.py maybe?
On Thu, Dec 20, 2018 at 7:33 AM Neale Ranns via Lists.Fd.Io <nranns=
cisco....@lists.fd.io> wrote:
>
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note:
> expected ‘const u8 * {aka const unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
>
> extern void mac_address_decode (const u8 * in, mac_address_t * out);
>
>
>
>
>
> the argument is not of type “struct _vl_api_mac_address”
>
>
>
> do you need a ‘make wipe’ to regenerate the files derived from the gbp.api
> ?
>
>
>
> /neale
>
>
>
>
>
> *De : *<vpp-dev@lists.fd.io> au nom de Ole Troan <otr...@employees.org>
> *Date : *jeudi 20 décembre 2018 à 11:07
> *À : *Zhiyong Yang <zhiyong.y...@intel.com>
> *Cc : *"vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io>
> *Objet : *Re: [vpp-dev] build errors on CenOS 7.5
>
>
>
> Hi,
>
>
>
> Paul also noticed that, and provided a fix in
> https://gerrit.fd.io/r/#/c/16562/
>
>
>
> Just merged.
>
> Can you confirm that fixes the issue?
>
> Also which compiler and version do you use?
>
>
>
> Cheers
>
> Ole
>
>
> On 20 Dec 2018, at 11:04, Zhiyong Yang <zhiyong.y...@intel.com> wrote:
>
> Hi VPP guys,
>
>
>
> Could you notice this building errors on CentOs as below?
> Could anybody help fix it?
>
>
>
> Regards
>
> Zhiyong
>
>
>
> Prefix path :
> /opt/vpp/external/x86_64;/root/zhiyong/vpp/build-root/install-vpp-native/external
>
> Install prefix : /root/zhiyong/vpp/build-root/install-vpp-native/vpp
>
> -- Configuring done
>
> -- Generating done
>
> -- Build files have been written to:
> /root/zhiyong/vpp/build-root/build-vpp-native/vpp
>
> [560/1042] Building C object
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
>
> FAILED: plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o
>
> /opt/rh/devtoolset-7/root/bin/cc -Dgbp_plugin_EXPORTS
> -I/root/zhiyong/vpp/src -I. -Iinclude -I/root/zhiyong/vpp/src/plugins
> -Iplugins -march=corei7 -mtune=corei7-avx -g -O2 -DFORTIFY_SOURCE=2
> -fstack-protector -fPIC -Werror -fPIC -Wno-address-of-packed-member -Wall
> -MD -MT plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -MF
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o.d -o
> plugins/gbp/CMakeFiles/gbp_plugin.dir/gbp_api.c.o -c
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function
> ‘vl_api_gbp_endpoint_add_t_handler’:
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:157:23: error: incompatible
> type for argument 1 of ‘mac_address_decode’
>
> mac_address_decode (mp->endpoint.mac, &mac);
>
> ^~
>
> In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note:
> expected ‘const u8 * {aka const unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
>
> extern void mac_address_decode (const u8 * in, mac_address_t * out);
>
> ^~~~~~~~~~~~~~~~~~
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function
> ‘gbp_endpoint_send_details’:
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:263:44: error: incompatible
> type for argument 2 of ‘mac_address_encode’
>
> mac_address_encode (&ge->ge_key.gek_mac, mp->endpoint.mac);
>
> ^~
>
> In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:26:13: note:
> expected ‘u8 * {aka unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka struct _vl_api_mac_address}’
>
> extern void mac_address_encode (const mac_address_t * in, u8 * out);
>
> ^~~~~~~~~~~~~~~~~~
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: In function
> ‘gbp_next_hop_decode’:
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:824:23: error: incompatible
> type for argument 1 of ‘mac_address_decode’
>
> mac_address_decode (in->mac, &mac);
>
> ^~
>
> In file included from /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c:24:0:
>
> /root/zhiyong/vpp/src/vnet/ethernet/ethernet_types_api.h:25:13: note:
> expected ‘const u8 * {aka const unsigned char *}’ but argument is of type
> ‘vl_api_mac_address_t {aka const struct _vl_api_mac_address}’
>
> extern void mac_address_decode (const u8 * in, mac_address_t * out);
>
> ^~~~~~~~~~~~~~~~~~
>
> /root/zhiyong/vpp/src/plugins/gbp/gbp_api.c: At top level:
>
> cc1: error: unrecognized command line option
> ‘-Wno-address-of-packed-member’ [-Werror]
>
> cc1: all warnings being treated as errors
>
> [633/1042] Building C object
> plugins/acl/CMakeFiles/acl_plugin_avx2.dir/dataplane_node.c.o
>
> ninja: build stopped: subcommand failed.
>
> make[1]: *** [vpp-build] Error 1
>
> make[1]: Leaving directory `/root/zhiyong/vpp/build-root'
>
> make: *** [build-release] Error 2
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#11725): https://lists.fd.io/g/vpp-dev/message/11725
> Mute This Topic: https://lists.fd.io/mt/28810001/675193
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [otr...@employees.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
>
> View/Reply Online (#11732): https://lists.fd.io/g/vpp-dev/message/11732
> Mute This Topic: https://lists.fd.io/mt/28810001/1594641
> Group Owner: vpp-dev+ow...@lists.fd.io
> Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [
> pvi...@vinciconsulting.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#11737): https://lists.fd.io/g/vpp-dev/message/11737
Mute This Topic: https://lists.fd.io/mt/28810001/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
