Re: [U-Boot] [PATCH] disk/part.c: 'usb storage' avoiding overflow when output capacity

2010-08-08 Thread Sergei Shtylyov
Hello. Sergei Trofimovich wrote: > Before: > Marvell>> usb storage > Device 0: Vendor: StoreJet Rev: Prod: Transcend > Type: Hard Disk > Capacity: 28759.9 MB = 28.0 GB (488397168 x 512) > After: > Marvell>> usb storage > Device 0: Vendor: Stor

Re: [U-Boot] [PATCH] usb: musb: set target address for non-multipoint devices

2010-08-09 Thread Sergei Shtylyov
Mike Frysinger wrote: > From: Bryan Wu > Signed-off-by: Bryan Wu > Signed-off-by: Cliff Cai > Signed-off-by: Mike Frysinger > --- > drivers/usb/musb/musb_hcd.c |7 +++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/musb/musb_hcd.c b/drivers/usb/musb/

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-10 Thread Sergei Shtylyov
Hello. Mike Frysinger wrote: > From: Bryan Wu > This is a change similar to what is already in the Linux driver. We > should only program the CLRDATATOG bit when the current mode indicates > that it is needed. > Signed-off-by: Bryan Wu > Signed-off-by: Cliff Cai > Signed-off-by: Mike Frysin

Re: [U-Boot] [PATCH] Fixing spi erase for S25FL128P_256K

2010-08-10 Thread Sergei Shtylyov
Hello. Marc-André Hébert wrote: > The spansion_erase currently only works when the sector size is 64KB. > cmd[1] should contain the higher 8 bit of the 24 bit address of the > sector to be erased. Currently it is holding the sector index to be > erased which happens to be the same thing when the

Re: [U-Boot] [PATCH] USB-CDC: correct wrong alignment in ether.c

2010-08-12 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: > The buffer for the status request must be word aligned > because it is accessed with 32 bit pointer in the > eth_status_complete function. You don't tell anything here about why the size of the array becomes 16x with your patch... > Signed-off-by: Stefano Babi

Re: [U-Boot] [PATCH] USB-CDC: add missing variable in ether.c

2010-08-12 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: > qmult was not defined if OTG dualspeed is set. > Signed-off-by: Stefano Babic > --- > drivers/usb/gadget/ether.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c > index e0ebf75..

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-12 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: > Take debug printout macros back from linux-2.6.27 and make them more > useful and more compatible. > Signed-off-by: Vitaly Kuzmichev > --- > drivers/usb/gadget/ether.c | 65 > +++- > 1 files changed, 34 insertions(+),

Re: [U-Boot] [PATCH] USB-CDC: wrong ep status used

2010-08-12 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: >> On 08/12/2010 01:41 AM, Stefano Babic wrote: >>> #if defined(DEV_CONFIG_CDC) >>> if (dev->status_ep) { >>> - dev->stat_req = usb_ep_alloc_request(gadget->ep0, GFP_KERNEL); >>> - dev->stat_req->buf = status_req; >>> + dev->stat_req

Re: [U-Boot] [PATCH 7/8] USB: gadget: ethernet error path potential oops fix

2010-08-12 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: > From: David Brownell > Fix potential (never-observed) oops on rare error path, > bugzilla #9594. Fix uses the same test as used earlier. I think references to bugzilla.kernel.org bugs look out of place in the U-Boot patch's changelog. > Also make the adj

Re: [U-Boot] [PATCH] usb: musb: only write CLRDATATOG when appropriate

2010-08-13 Thread Sergei Shtylyov
Hello. Remy Bohmer wrote: >>> Mike Frysinger wrote: --- a/drivers/usb/musb/musb_hcd.c +++ b/drivers/usb/musb/musb_hcd.c } else { - if (!toggle) - writew(MUSB_RXCSR_CLRDATATOG, &musbr->rxcsr); - else { +

Re: [U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

2010-08-13 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: >>> -printf ("enable %s --> %d\n", >>> +DEBUG(dev, "enable %s --> %d\n", >> Well, I think the coding style shouldbe consistent -- you either leave >> the space before ( or remove it. And as U-Boot seems to follow the Linux >> coding style

Re: [U-Boot] [PATCH v2 3/8] USB-CDC: Use native debug printout macros

2010-08-13 Thread Sergei Shtylyov
Hello. Vitaly Kuzmichev wrote: > Rogan Dawes wrote: >>> +#define DEBUG >>> +#undef DEBUG >>> + >> Eh? > Such thing is used to let someone know that this driver supports debug > output through native U-Boot macros. So one need to comment #undef to > compile ether.c with debug messages. > There

Re: [U-Boot] [PATCH] Add mvsata support for the Sheevaplug devices

2010-08-14 Thread Sergei Shtylyov
Hello. GEAK wrote: > Add mvsata support to SHEEVAPLUG > Signed-off-by: Gérald Kerma > --- > include/configs/sheevaplug.h | 29 + > 1 files changed, 29 insertions(+), 0 deletions(-) > diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h > i

Re: [U-Boot] [PATCH V2 1/2] USB-CDC: correct wrong alignment in ether.c

2010-08-14 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: > The buffer for the status request must be word aligned > because it is accessed with 32 bit pointer in the > eth_status_complete function. > Signed-off-by: Stefano Babic [...] > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c > index 313f15f..0

Re: [U-Boot] [PATCH V2 2/2] USB-CDC: called handle_interrupts inside usb_eth_send

2010-08-14 Thread Sergei Shtylyov
Stefano Babic wrote: > The patch removes an endless loop in the usb_eth_send > if the tx_complete is not called before going > in the loop. The driver interrupt routine is called > allowing the driver to check if the TX is completed. > Signed-off-by: Stefano Babic > --- [...] > diff --git a/d

Re: [U-Boot] [PATCH] MX51: add structure to access System Reset Controller

2010-08-20 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: > Signed-off-by: Stefano Babic [...] > diff --git a/arch/arm/include/asm/arch-mx51/imx-regs.h > b/arch/arm/include/asm/arch-mx51/imx-regs.h > index 0e3bc2a..06f2720 100644 > --- a/arch/arm/include/asm/arch-mx51/imx-regs.h > +++ b/arch/arm/include/asm/arch-mx51/imx-re

Re: [U-Boot] [PATCH 05/13] x86: Make CONFIG_RELOC_FIXUP_WORKS generic for all x86 boards

2010-08-23 Thread Sergei Shtylyov
Hello. Graeme Russ wrote: > Relocation is not board-specific fir the x86 architectrure, so s/fir/for/ > CONFIG_RELOC_FIXUP_WORKS can be defined globally in the common.h You mean config.h? > Signed-off-by: Graeme Russ [...] > diff --git a/arch/i386/include/asm/config.h b/arch/i386/inc

Re: [U-Boot] [PATCH 5/8] APM82xxx: Add UIC support

2010-08-27 Thread Sergei Shtylyov
Hello. tma...@apm.com wrote: > From: Tirumala Marri > This patch adds Universal Interrupt Controller support for > APM82XXX processor. > Signed-off-by: Tirumala R Marri [...] > diff --git a/arch/powerpc/include/asm/ppc4xx-uic.h > b/arch/powerpc/include/asm/ppc4xx-uic.h > index 782d045..238b7

Re: [U-Boot] [PATCH 6/8] APM82xxx: Add SRAM support

2010-08-27 Thread Sergei Shtylyov
Hello. tma...@apm.com wrote: > From: Tirumala Marri > This patch adds L2Cache/SRAM and OCM register definitions. > Signed-off-by: Tirumala R Marri [...] > diff --git a/arch/powerpc/include/asm/ppc4xx-isram.h > b/arch/powerpc/include/asm/ppc4xx-isram.h > index d6d17ac..b723401 100644 > --- a/

Re: [U-Boot] [PATCH] arm, orion5x: fix comilerwarning for edminiv2 board

2010-08-31 Thread Sergei Shtylyov
Hello. Heiko Schocher wrote: > compiling edminiv2 board throws following warning: > Configuring for edminiv2 board... > In file included from /home/hs/i2c/u-boot-i2c/include/asm/arch/orion5x.h:39, > from cpu.c:32: And? Where's the warning text? :-) > introduced from commi

Re: [U-Boot] [PATCH 2/4] cfi_flash: Add weak default for cfi_flash_bank_addr()

2010-09-01 Thread Sergei Shtylyov
Hello. Stefan Roese wrote: > cfi_flash_bank_addr(int bank_nr) returns the base addresses of the > requested bank. Introducing this weak default enables boards to override > this functions with a board specific version when required. > This feature will be used in the lwmon5 board update, support

Re: [U-Boot] [PATCH] mvsata_ide: adjust port init sequence

2010-09-05 Thread Sergei Shtylyov
Hello. On 04-09-2010 14:34, Albert Aribaud wrote: > mvsata_ide_initialize_port(): adjust init sequence (SStatus > should be checked only after all writes to SControl) and > return success/failure to ide_preinit(). > Also, as some tests showed init durations in the hundreds > of us, raise the tim

Re: [U-Boot] [PATCH V2 08/11] mtd: nand: supress 'unknown NAND' warning if no nand is found

2010-09-05 Thread Sergei Shtylyov
Hello. On 02-09-2010 19:33, Steve Sakoman wrote: > This printk was added recently and results in ugly output on systems > with no NAND: > NAND: nand_get_flash_type: unknown NAND device: Manufacturer ID: 0x00, Chip > ID: 0x00 0 MiB > instead of: > NAND: 0 MiB > Signed-off-by: Steve Sakoman

Re: [U-Boot] [PATCH] mvsata_ide: adjust port init sequence

2010-09-06 Thread Sergei Shtylyov
Hello. On 05.09.2010 23:33, Albert ARIBAUD wrote: >>> + /* Set control IPM to 3 (no low power) and DET to 1 (initialize) */ >>> control = readl(&port->scontrol); >>> control = (control & ~MVSATA_SCONTROL_MASK) | MVSATA_PORT_INIT; >>> + /* Toggle control DET back to 0 (normal operation) */ >> But

Re: [U-Boot] [PATCH] mvsata_ide: adjust port init sequence

2010-09-06 Thread Sergei Shtylyov
Hello. Albert ARIBAUD wrote: >> On 05.09.2010 23:33, Albert ARIBAUD wrote: > + /* Set control IPM to 3 (no low power) and DET to 1 (initialize) */ > control = readl(&port->scontrol); > control = (control & ~MVSATA_SCONTROL_MASK) | MVSATA_PORT_INIT; > + /* Toggle control DET back

Re: [U-Boot] [PATCH V2] mvsata_ide: adjust port init sequence

2010-09-07 Thread Sergei Shtylyov
Hello. On 07-09-2010 3:02, Albert Aribaud wrote: > mvsata_ide_initialize_port(): adjust init sequence (SStatus > should be checked only after all writes to SControl) and > return success/failure to ide_preinit(). > Also, as some tests showed init durations in the hundreds > of us, raise the time

Re: [U-Boot] [PATCH 5/5] DockStar: LED support

2010-09-08 Thread Sergei Shtylyov
Hello. On 07-09-2010 18:28, Eric Cooper wrote: > derived from patches posted by Jeff Doozan > in the uBoot forum at http://forum.doozan.com > Signed-off-by: Eric Cooper [...] > diff --git a/board/Marvell/dockstar/dockstar.c > b/board/Marvell/dockstar/dockstar.c > index 13cd347..7788837 100644 >

Re: [U-Boot] [PATCH 1/2] mmc: add boundary check for mmc operation

2010-09-13 Thread Sergei Shtylyov
Hello. On 13-09-2010 8:06, Lei Wen wrote: > Signed-off-by: Lei Wen > --- > drivers/mmc/mmc.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index cf4ea16..5ff1c54 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mm

Re: [U-Boot] [PATCH 2/2] mmc: print out avaible partition table

2010-09-13 Thread Sergei Shtylyov
Hello. On 13-09-2010 8:06, Lei Wen wrote: > Signed-off-by: Lei Wen > --- > common/cmd_mmc.c | 20 > disk/part.c |3 +++ > 2 files changed, 23 insertions(+), 0 deletions(-) > diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c > index c0b30d8..fe04f8d 100644 > ---

Re: [U-Boot] [PATCH 1/2 V2] mmc: add boundary check for mmc operation

2010-09-13 Thread Sergei Shtylyov
Hello. Lei Wen wrote: > Change log: > change the puts to printf to better formating. This change log should have followed the "---" tear-line. > Signed-off-by: Lei Wen > --- WBR, Sergei ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.d

Re: [U-Boot] [PATCH 2/2 V2] mmc: print out avaible partition table

2010-09-13 Thread Sergei Shtylyov
Hello. Lei Wen wrote: > Signed-off-by: Lei Wen [...] > diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c > index c0b30d8..437dd88 100644 > --- a/common/cmd_mmc.c > +++ b/common/cmd_mmc.c [...] > @@ -230,5 +249,6 @@ U_BOOT_CMD( > "read addr blk# cnt\n" > "mmc write addr blk# cnt\n"

Re: [U-Boot] [PATCH 2/2] [NEXT] edminiv2: enable relocation

2010-09-22 Thread Sergei Shtylyov
Hello. On 21-09-2010 23:35, Albert Aribaud wrote: > Signed-off-by: Albert Aribaud [...] > diff --git a/board/LaCie/edminiv2/config.mk b/board/LaCie/edminiv2/config.mk > index 3dec1aa..b4845ad 100644 > --- a/board/LaCie/edminiv2/config.mk > +++ b/board/LaCie/edminiv2/config.mk > @@ -24,4 +24,6 @@

Re: [U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices

2010-09-30 Thread Sergei Shtylyov
Hello. On 29-09-2010 23:05, Peter Tyser wrote: > Add the ability to not report an I2C POST error for a set of given I2C > addresses on bootup. This is useful for the following cases: > - Some form factors such as XMC and Compact PCI Express have an I2C >EEPROM whose address changes based on

Re: [U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices

2010-09-30 Thread Sergei Shtylyov
Hello. Peter Tyser wrote: +#ifdef I2C_ADDR_IGNORE_LIST + unsigned char i2c_ignore_list[] = I2C_ADDR_IGNORE_LIST; >>> This array is aking to be *static*... >> ... and *const* as well ? > I'll add 'const' in the next version, but I'm not sure if the 'static' > adds any benefit sin

Re: [U-Boot] [PATCH 13/17] post/i2c: Add ability to ignore I2C devices

2010-09-30 Thread Sergei Shtylyov
Hello. Peter Tyser wrote: >> +#ifdef I2C_ADDR_IGNORE_LIST >> +unsigned char i2c_ignore_list[] = I2C_ADDR_IGNORE_LIST; > This array is aking to be *static*... ... and *const* as well ? >>> I'll add 'const' in the next version, but I'm not sure if the 'static' >>> ad

Re: [U-Boot] [PATCH 2/4] OneNAND: Fixup command table on reloc

2010-10-03 Thread Sergei Shtylyov
Hello. On 02-10-2010 21:33, Marek Vasut wrote: > Signed-off-by: Marek Vasut [...] > diff --git a/common/cmd_onenand.c b/common/cmd_onenand.c > index 83d967b..fe84c3b 100644 > --- a/common/cmd_onenand.c > +++ b/common/cmd_onenand.c > @@ -525,6 +525,12 @@ static cmd_tbl_t cmd_onenand_sub[] = { >

Re: [U-Boot] [PATCH 03/19] x86: zboot update

2010-10-04 Thread Sergei Shtylyov
Hello. On 04-10-2010 7:37, Graeme Russ wrote: > The header of recent Linux Kernels includes the size of the image, and > therefore is not needed to be passed to zboot. Still process the third > parameter (size of image) in the event that an older kernel is being loaded > Signed-off-by: Graeme Ru

Re: [U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation

2010-10-04 Thread Sergei Shtylyov
Hello. On 04-10-2010 7:37, Graeme Russ wrote: > To allow for 'load anywhere' images, the %ebp return pointer 'hack' must > be removed, so we cannot have two 'calls' to get_mem_size > Signed-off-by: Graeme Russ [...] > diff --git a/arch/i386/cpu/start.S b/arch/i386/cpu/start.S > index cb47ce7..9

Re: [U-Boot] [PATCH] env: fix cmd_env_sub fct pointers if CONFIG_RELOC_FIXUP_WORKS is not defined

2010-10-05 Thread Sergei Shtylyov
Hello. On 05-10-2010 9:41, Heiko Schocher wrote: > commit ea882baf9c17cd142c99e3ff640d3ab01daa5cec introduces > a command_sub_table for the "env" command. On arm, avr32, m68k, > mips and sparc architectures, relocation needs manual fixups, > so add these fixups for this sub command table too. >

Re: [U-Boot] [PATCH 2/4] sf: spansion: fixing erasing when sector size >64KiB

2010-10-06 Thread Sergei Shtylyov
Hello. On 06-10-2010 11:37, Mike Frysinger wrote: > From: Marc-André Hébert > The spansion_erase currently only works when the sector size is 64KB. > cmd[1] should contain the higher 8 bit of the 24 bit address of the > sector to be erased. Currently it is holding the sector index to be > erased

Re: [U-Boot] [PATCH] Crash in env_relocate_spec() of env_mmc.c

2010-10-08 Thread Sergei Shtylyov
Hello. On 08-10-2010 12:03, Stefano Babic wrote: > mmc_initialize is not called at the startup if the > relocation takes place and the environment is stored > into a MMC card. > Signed-off-by: Stefano Babic [...] > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c > index 5f2dfd0..704ddc

Re: [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation

2010-10-10 Thread Sergei Shtylyov
Hello. On 09-10-2010 1:49, Steve Sakoman wrote: > The crash was occuring in env_relocate because it was being called prior > to mmc_initialize. This patch moves the MMC initialization earlier in > the init process. > This patch also cleans up the env_relocate_spec code in env_mmc.c > Developed

Re: [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation

2010-10-10 Thread Sergei Shtylyov
Hello. On 10-10-2010 17:42, Steve Sakoman wrote: >>> The crash was occuring in env_relocate because it was being called prior >>> to mmc_initialize. This patch moves the MMC initialization earlier in >>> the init process. >>> This patch also cleans up the env_relocate_spec code in env_mmc.c >>

Re: [U-Boot] env_mmc: Fix crashing bug encountered after enabling ARM relocation

2010-10-10 Thread Sergei Shtylyov
On 10-10-2010 19:47, Steve Sakoman wrote: > The crash was occuring in env_relocate because it was being called prior > to mmc_initialize. This patch moves the MMC initialization earlier in > the init process. > This patch also cleans up the env_relocate_spec code in env_mmc.c >>

[U-Boot] [PATCH] fat: reset VFAT short alias checksum on first match

2012-01-02 Thread Sergei Shtylyov
The VFAT short alias checksum read from a long file name is only overwritten when another long file name appears in a directory list. Until then it renders short file names invisible that have the same checksum. Reset the checksum on first match. Signed-off-by: Sergei Shtylyov Signed-off-by

Re: [U-Boot] [PATCH v2] Fix wrong loop bound in flush_cache() when "size" is zero

2011-08-09 Thread Sergei Shtylyov
Hello. On 08-08-2011 17:57, Yao Cheng wrote: > The issue is found when calling flush_cache() with zero "size" argument. > The bound of loop is miscalculated in this case and flush_cache() enters a > wrong flushing loop. > To fix this issue I skipped the operations when "size" is found to be zero

Re: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors

2011-08-11 Thread Sergei Shtylyov
Hello. On 10-08-2011 11:12, Joe Hershberger wrote: > Previously only the last N were included based on the current one in use. > Signed-off-by: Joe Hershberger > Cc: Joe Hershberger > Cc: Mingkai Hu > Cc: Andy Fleming > Cc: Kumar Gala > Cc: Detlev Zundel > --- > drivers/net/tsec.c |4 ++--

Re: [U-Boot] [PATCH 5/7] led: Fixed setting of STATUS_LED_BIT1 when led_name is 'all'

2011-08-16 Thread Sergei Shtylyov
Hello. On 16-08-2011 6:42, Joel A Fernandes wrote: > Fix for only one led getting set or reset when the led_name is 'all' > Previous discussion: > http://lists.denx.de/pipermail/u-boot/2011-May/093068.html > Signed-off-by: Joel A Fernandes > Signed-off-by: Jason Kridner > --- > common/cmd_led

Re: [U-Boot] [PATCH v2] armv7:cache: D cache line size read method

2011-08-16 Thread Sergei Shtylyov
Hello. On 16-08-2011 14:31, Lukasz Majewski wrote: > This commit adds support for reading the D cache line size for armv7 > architecture. > The get_dcache_line_size() function is supposed to work in conjunction > with memalign call to provide D cache aligned DMA buffers. > Signed-off-by: Lukasz

Re: [U-Boot] [PATCH] FAT: Add FAT write feature

2011-08-16 Thread Sergei Shtylyov
Hello. On 16-08-2011 14:22, Donggeun Kim wrote: > In some cases, saving data in RAM as a file with FAT format is required. > This patch allows the file to be written in FAT formatted partition. > > The usage is similar with reading a file. > First, fat_register_device function is called before fi

[U-Boot] [PATCH 1/2] fat: root directory cluster only makes sense for FAT32

2011-08-19 Thread Sergei Shtylyov
The root directory cluster field only exists in a FAT32 boot sector, so the 'root_cluster' variable in do_fat_read() contains garbage in case of FAT12/16. Make it contain 0 instead as this is what is passed to get_vfatname() in that case anyway. Signed-off-by: Sergei Shtylyov

[U-Boot] [PATCH 2/2] fat: replace LINEAR_PREFETCH_SIZE with PREFETCH_BLOCKS

2011-08-19 Thread Sergei Shtylyov
_SIZE. Signed-off-by: Sergei Shtylyov --- Slight optimization atop of commit 3831530dcb7b71329c272ccd6181f8038b6a6dd0 (VFAT: fix processing of scattered long file name entries) and my recently submitted patch fixing crash with big sector size. The patch was generated atop of the below patches p

Re: [U-Boot] [PATCH V2 1/2] net/eth.c: throw BUG for eth_get_dev_by_name(NULL)

2011-08-22 Thread Sergei Shtylyov
Hello. On 22-08-2011 12:45, Helmut Raiger wrote: > eth_get_dev_by_name() is not safe to use for devname being NULL > as it uses strcmp. This patch makes it fail with a BUG(). > Signed-off-by: Helmut Raiger > --- > V2: use BUG_ON() instead of gracefully returning 0 > net/eth.c |2 ++ > 1

Re: [U-Boot] [PATCH V3 8/8] savebp: added Readme

2011-08-26 Thread Sergei Shtylyov
Hello. On 25-08-2011 12:33, Simon Schwarz wrote: > Adds a Readme for the savebp command > Signed-off-by: Simon Schwarz [...] > diff --git a/doc/README.commands.savebp b/doc/README.commands.savebp > new file mode 100644 > index 000..dc05ee0 > --- /dev/null > +++ b/doc/README.commands.savebp

Re: [U-Boot] [PATCH] Write MAC address whenever ethernet subsystem is initialized

2011-08-26 Thread Sergei Shtylyov
Hello. On 26-08-2011 13:24, Ingo van Lil wrote: > Currently the ethernet MAC address is read from the 'ethaddr' > environment variable into the dev->enetaddr field each time the network > hardware is initialized, but it is written to the actual hardware only > once at board startup. When 'ethaddr

Re: [U-Boot] [PATCH] PPC4xx: ALPR: constify FPGA code

2011-09-05 Thread Sergei Shtylyov
Hello. On 05-09-2011 13:43, Wolfgang Denk wrote: > The ALPR custom FPGA code was missed by commit e6a857d "fpga: > constify to fix build warning" resulting in such warnings: > fpga.c:226: warning: initialization from incompatible pointer type > Signed-off-by: Wolfgang Denk > Cc: Stefan Roese >

Re: [U-Boot] [PATCH 1/2] mx31pdk: Disable watchdog

2011-09-16 Thread Sergei Shtylyov
Hello. On 16-09-2011 3:18, Fabio Estevam wrote: > When booting a mainline kernel on a mx31pdk the system gets getting resets > from the watchdog. That's tautological. Maybe "is getting reset"? > As the kernel has watchdog support, disable it from U-boot. > Signed-off-by: Fabio Estevam WB

[U-Boot] [PATCH] DaVinci: correct PDSTAT.STATE mask

2011-09-16 Thread Sergei Shtylyov
MDSTAT.STATE occupies bits 0..5 according to all available documentation, so fix the masks which previously was leaving out the itermediate state indicator bit. Signed-off-by: Sergei Shtylyov --- Analogous Linux patch has been queued in the linux-davinci tree: http://linux.davincidsp.com

Re: [U-Boot] [PATCH v2] DaVinci: correct MDSTAT.STATE mask

2011-09-16 Thread Sergei Shtylyov
MDSTAT.STATE occupies bits 0..5 according to all available documentation, so fix the masks which previously was leaving out the intermediate state indicator bit. Signed-off-by: Sergei Shtylyov --- Resending with the corrected subject/description... Analogous Linux patch has been queued in the

Re: [U-Boot] [PATCH v2] DaVinci: correct MDSTAT.STATE mask

2011-09-17 Thread Sergei Shtylyov
Hello. On 17-09-2011 1:01, Wolfgang Denk wrote: > Dear Sergei Shtylyov, Thank you for the really quick response. :-) >> MDSTAT.STATE occupies bits 0..5 according to all available documentation, so >> fix >> the masks which previously was leaving out the interme

[U-Boot] [PATCH 1/4] EHCI: fix root hub device descriptor

2010-02-27 Thread Sergei Shtylyov
On little endian machines, EHCI root hub's USB revision is reported as 0.2 -- cpu_to_le16() was missed in the initializer for the 'bcdUSB' descriptor field. The same should be done for the 'bcdDevice' field. Signed-off-by: Sergei Shtylyov --- drivers/usb/host/ehci-

[U-Boot] [PATCH 2/4] EHCI: fix off-by-one error in ehci_submit_root()

2010-02-27 Thread Sergei Shtylyov
USB devices on the 2nd port are not detected and I get the following message: The request port(1) is not configured That's with default CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS value of 2. 'req->index' is 1-based, so the comparison in ehci_submit_root() can't be correct.

[U-Boot] [PATCH 3/4] EHCI: fix port reset reporting

2010-02-27 Thread Sergei Shtylyov
t was already completed. Signed-off-by: Sergei Shtylyov --- drivers/usb/host/ehci-hcd.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) Index: u-boot/drivers/usb/host/ehci-hcd.c === --- u-boot

[U-Boot] [PATCH 4/4] EHCI: add NEC PCI ID

2010-02-27 Thread Sergei Shtylyov
Add NEC EHCI controller to the list of the supported devices. Signed-off-by: Sergei Shtylyov drivers/usb/host/ehci-pci.c |1 + 1 file changed, 1 insertion(+) Index: u-boot/drivers/usb/host/ehci-pci.c === --- u-boot.orig

Re: [U-Boot] [PATCH v3] nios2: add gpio support

2010-04-17 Thread Sergei Shtylyov
Hello. Thomas Chou wrote: > This patch adds driver for a trivial gpio core, which is described > in http://nioswiki.com/GPIO. > > When CONFIG_SYS_GPIO_BASE is not defined, board may provide > its own driver. > > Signed-off-by: Thomas Chou > --- > arch dir reorganized. > > arch/nios2/include/asm

Re: [U-Boot] [PATCH 1/3] Support for devices with FAT32 PBR

2010-05-10 Thread Sergei Shtylyov
Hello. Igor Luri wrote: > Signed-off-by: Igor Luri > --- > disk/part_dos.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/disk/part_dos.c b/disk/part_dos.c > index 887b75e..d91f773 100644 > --- a/disk/part_dos.c > +++ b/disk/part_dos.c > @@ -77,7 +77,8 @@ static

Re: [U-Boot] [PATCH v3] Support for devices with FAT32 PBR

2010-05-10 Thread Sergei Shtylyov
Hello. Igor Luri wrote: > Signed-off-by: Igor Luri > --- > disk/part_dos.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/disk/part_dos.c b/disk/part_dos.c > index 887b75e..d91f773 100644 > --- a/disk/part_dos.c > +++ b/disk/part_dos.c > @@ -77,7 +77,8 @@ static

Re: [U-Boot] [PATCH v3] Support for devices with FAT32 PBR

2010-05-11 Thread Sergei Shtylyov
al commits as a single commit -- git-format-patch won't help here. > I would apreciate any help. > > Best regards. > > > > El lun, 10-05-2010 a las 19:22 +0400, Sergei Shtylyov escribió: > >> Hello. >> >> Igor Luri wrote: >> >> &g

Re: [U-Boot] [PATCH v2] microblaze: Disabling interrupt should return 1 if was enabled

2010-12-21 Thread Sergei Shtylyov
Hello. On 21-12-2010 16:02, Michal Simek wrote: > Microblaze implement enable/disable interrupts through MSR > that's why disable_interrupts function should return 1 when interrupt > was enabled. Return 0 when interrupt was disabled. > Signed-off-by: John Linn > Signed-off-by: Michal Simek [...]

Re: [U-Boot] [PATCH v2 1/9] mpc8xxx: Display RDIMM if detected

2010-12-21 Thread Sergei Shtylyov
Hello. On 19-12-2010 1:21, Wolfgang Denk wrote: >> Print a message when a RDIMM is detected. > ... >> +} else >> printf("ERROR: Mix of registered buffered and unbuffered " >> "DIMMs detected!\n"); >> -} > Mutli-line statement needs braces.

Re: [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style

2010-12-22 Thread Sergei Shtylyov
Hello. On 21-12-2010 21:12, Michal Simek wrote: > Clear coding style issues. > Signed-off-by: Michal Simek [...] > diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c > index 2209561..f1af7e2 100644 > --- a/lib/asm-offsets.c > +++ b/lib/asm-offsets.c > @@ -19,11 +19,11 @@ > > #include > > -int

Re: [U-Boot] [PATCH] Correct chip detect logic

2010-12-27 Thread Sergei Shtylyov
Hello. On 26-12-2010 5:41, Yanjun Yang wrote: > The lan91c96_detect_chip routine is not correct according > to the manual. > Signed-off-by: YanJun Yang [...] > diff --git a/drivers/net/lan91c96.c b/drivers/net/lan91c96.c > index bd6966e..2550aa2 100644 > --- a/drivers/net/lan91c96.c > +++ b/dri

Re: [U-Boot] [PATCH] nios2: add gpio_is_valid

2010-12-27 Thread Sergei Shtylyov
Hello. On 27-12-2010 5:46, Thomas Chou wrote: > Signed-off-by: Thomas Chou [...] > diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h > index 36a7132..4b21c8f 100644 > --- a/arch/nios2/include/asm/gpio.h > +++ b/arch/nios2/include/asm/gpio.h > @@ -52,6 +52,11 @@ static in

Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2010-12-27 Thread Sergei Shtylyov
Hello. On 27-12-2010 7:48, Mike Frysinger wrote: > The recent global data changes (making the size autogenerated) broke the > board info handling on Blackfin ports as we were lying and lumping the > bd_t size in with the gd_t size. So use the new dedicated bd_t size to > setup its own address in

Re: [U-Boot] [PATCH V2] mpc83xx: fix pcie configuration space read/write

2011-01-09 Thread Sergei Shtylyov
Hello. On 07-01-2011 15:42, Baidu Boy wrote: > This patch fix a problem for the pcie enumeration when the mpc83xx pcie > controller > is connected with switch or we use both of the two pcie controller. > Signed-off-by: Baidu Boy > --- > Changes for v2: > - Avoid line wrap in the patch >

Re: [U-Boot] [PATCH] mpc83xx: fix pcie configuration space read/write

2011-01-09 Thread Sergei Shtylyov
Hello. On 07-01-2011 15:29, Baidu Boy wrote: > This patch fix a problem for the pcie enumeration when the mpc83xx pcie > controller > is connected with switch or we use both of the two pcie controller. > Signed-off-by: Baidu Boy > --- > arch/powerpc/cpu/mpc83xx/pcie.c |8 ++-- > 1 fil

Re: [U-Boot] [PATCH 5/7] powerpc/86xx: Enable common SRIO init code

2011-01-09 Thread Sergei Shtylyov
Hello. On 06-01-2011 19:58, Kumar Gala wrote: > Add the needed defines and code to utilize the common 8xxx srio init > code to setup LAWs and modify device tree if we have SRIO enabled on a > board. > Signed-off-by: Kumar Gala > --- > arch/powerpc/cpu/mpc86xx/fdt.c|9 - >

Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-12 Thread Sergei Shtylyov
Hello. On 11-01-2011 17:52, seedshope wrote: > Since SDRAM init function have already change, So the SDRAM > initial function must be change. > Signed-off-by: seedshope > diff --git a/board/samsung/smdk6400/smdk6400.c > b/board/samsung/smdk6400/smdk6400.c > index 35aa40b..52b44a8 100644 > ---

Re: [U-Boot] [PATCH 15/28] Blackfin: fix bd_t handling

2011-01-12 Thread Sergei Shtylyov
On 11.01.2011 3:31, Mike Frysinger wrote: >>> it isnt a problem to have the parens, and it keeps things sane if someone >>> does something like: >>> #define CONFIG_SYS_BD_INFO_ADDR SOME_DEFINE + 0x1000 >> This would be a violation of basic rules of defensive coding. >> Please drop these parens

Re: [U-Boot] [V2 patch 4/4] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-13 Thread Sergei Shtylyov
Hello. On 12-01-2011 17:52, seedshope wrote: >>> Since SDRAM init function have already change, So the SDRAM >>> initial function must be change. >>> Signed-off-by: seedshope >>> diff --git a/board/samsung/smdk6400/smdk6400.c >>> b/board/samsung/smdk6400/smdk6400.c >>> index 35aa40b..52b44a8 10

Re: [U-Boot] USB storage performance EHCI question

2011-01-13 Thread Sergei Shtylyov
Hello. On 13-01-2011 9:09, Wolfgang Denk wrote: > Hm... I just notice the "caviumnetworks" in your address, so this is > probably MIPS? Check if your caches are turned on... BTW, Cavium also produces ARMs (like CNS3xxx)... > Best regards, > Wolfgang Denk WBR, Sergei _

Re: [U-Boot] [PATCH] mpc83xx:fix pcie configuration space read/write

2011-01-15 Thread Sergei Shtylyov
Hello. On 15-01-2011 14:22, Baidu Boy wrote: > This patch fix a problem for the pcie enumeration when the mpc83xx pcie > controller is > connected with switch or we use both of the two pcie controller. > Signed-off-by: Baidu Boy [...] > diff --git a/arch/powerpc/cpu/mpc83xx/pcie.c b/arch/powe

Re: [U-Boot] [PATCH V2 2/2] SPI: mxc_spi: add SPI clock calculation and setup to the driver

2011-01-18 Thread Sergei Shtylyov
Hello. Stefano Babic wrote: > From: Anatolij Gustschin > The MXC SPI driver didn't calculate the SPI clock up to > now and just highest possible divider 512 for DATA ^ I think "used" shouldn't have been ommitted here. > RATE in the control register. This results in very low

Re: [U-Boot] [PATCH 2/3] MX51EVK: Use SWx macros in PMIC init

2011-01-19 Thread Sergei Shtylyov
Hello. On 18-01-2011 22:30, Marek Vasut wrote: > Signed-off-by: Marek Vasut > diff --git a/board/freescale/mx51evk/mx51evk.c > b/board/freescale/mx51evk/mx51evk.c > index 2160d5a..bcf1934 100644 > --- a/board/freescale/mx51evk/mx51evk.c > +++ b/board/freescale/mx51evk/mx51evk.c > @@ -198,17 +19

Re: [U-Boot] [PATCH 2/3 RESEND] MX51EVK: Use SWx macros in PMIC init

2011-01-19 Thread Sergei Shtylyov
On 19-01-2011 2:19, Marek Vasut wrote: > Signed-off-by: Marek Vasut [...] > diff --git a/board/freescale/mx51evk/mx51evk.c > b/board/freescale/mx51evk/mx51evk.c > index 2160d5a..bcf1934 100644 > --- a/board/freescale/mx51evk/mx51evk.c > +++ b/board/freescale/mx51evk/mx51evk.c > @@ -198,17 +198,1

Re: [U-Boot] [PATCH] net: ftmac100: remove unncessary volatiles

2011-01-20 Thread Sergei Shtylyov
Hello. Po-Yu Chuang wrote: > From: Po-Yu Chuang > This patch also update get_timer() usage. This seems like a material for a separate patch. > Signed-off-by: Po-Yu Chuang > --- > drivers/net/ftmac100.c | 20 +--- > 1 files changed, 9 insertions(+), 11 deletions(-) > d

Re: [U-Boot] [v4 patch 6/6] SMDK6400: Fix SMDK6400 SDRAM init

2011-01-21 Thread Sergei Shtylyov
Hello. seedshope wrote: > Since SDRAM init function have already change, So the SDRAM > initial function must be change. This description sounds somewhat tautological... > Signed-off-by: seedshope Your real name is required in the signoff. > --- > board/samsung/smdk6400/smdk6400.c |

Re: [U-Boot] [PATCH] Fix gunzip to work for any gzipped uImage size Signed-off-by: Catalin Radu

2011-02-03 Thread Sergei Shtylyov
Hello. On 02-02-2011 19:41, Catalin Radu wrote: > diff --git a/lib/gunzip.c b/lib/gunzip.c > index 482a476..18cb45b 100644 > --- a/lib/gunzip.c > +++ b/lib/gunzip.c > @@ -106,12 +106,16 @@ int zunzip(void *dst, int dstlen, unsigned char *src, > unsigned long *lenp, > s.avail_in = *lenp - o

Re: [U-Boot] [PATCH] Fix gunzip to work for any gzipped uImage size Signed-off-by: Catalin Radu

2011-02-03 Thread Sergei Shtylyov
Your signoff line got "pasted" to the subject. WBR, Sergei ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] part_dos: allocate sector buffer dynamically

2011-04-12 Thread Sergei Shtylyov
Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it tries to read the MBR into 512-byte buffer situated on stack. Instead allocate this buffer dynamically to be safe with any large sector size. Signed-off-by: Sergei Shtylyov --- The same change is probably needed for

Re: [U-Boot] [PATCH] MX51: mx51evk: Use struct to access SRSR register instead of offset

2011-04-13 Thread Sergei Shtylyov
Hello. On 13-04-2011 7:02, Fabio Estevam wrote: > Signed-off-by: Fabio Estevam > --- > board/freescale/mx51evk/mx51evk.c |6 +- > 1 files changed, 5 insertions(+), 1 deletions(-) > diff --git a/board/freescale/mx51evk/mx51evk.c > b/board/freescale/mx51evk/mx51evk.c > index 02a765d..3

Re: [U-Boot] [PATCH] part_dos: allocate sector buffer dynamically

2011-05-03 Thread Sergei Shtylyov
afe with any large sector size. >> Signed-off-by: Sergei Shtylyov > Can we please keep the buffer on the stack as before? It will be unsafe. We can't really predict the size of the buffer (unless we postulate that the buffer size won't ever exceed e.g. 4K). > There is no nee

Re: [U-Boot] [PATCH] part_dos: allocate sector buffer dynamically

2011-05-03 Thread Sergei Shtylyov
Hello. On 03-05-2011 16:34, Wolfgang Denk wrote: > Umm... you _are_ aware that you can put dynamically sized arrays on > the stack, aren't you? No, it seems I'm not. Is it a standard C now? > Best regards, > Wolfgang Denk WBR, Sergei ___ U-Boot

Re: [U-Boot] [PATCH] post: add gpio hotkey support

2011-05-11 Thread Sergei Shtylyov
Hello. On 10-05-2011 21:01, Mike Frysinger wrote: > Now that we have the generic GPIO layer, we can easily provide a common > implementation for the post_hotkeys_pressed() function based on it. > Signed-off-by: Mike Frysinger > --- > post/post.c | 21 + > 1 files changed

Re: [U-Boot] [PATCH] post: add gpio hotkey support

2011-05-12 Thread Sergei Shtylyov
Hello. On 11-05-2011 18:54, Mike Frysinger wrote: >>> @@ -68,6 +72,23 @@ int post_init_f (void) >>>int __post_hotkeys_pressed(void) >>>{ >>> +#ifdef CONFIG_SYS_POST_HOTKEYS_GPIO >>> + int ret; >>> + unsigned gpio = CONFIG_SYS_POST_HOTKEYS_GPIO; >>> + >>> + ret = gpio_request(gpio, "

Re: [U-Boot] [PATCHv2] bootp: add ntpserver option to bootp request

2011-05-16 Thread Sergei Shtylyov
Hello. On 16-05-2011 6:24, Chris Packham wrote: > From: Luuk Paulussen > Signed-off-by: Luuk Paulussen > Acked-by: Chris Packham > Cc: Ben Warren [...] > diff --git a/net/bootp.c b/net/bootp.c > index 4db63cb..18c743e 100644 > --- a/net/bootp.c > +++ b/net/bootp.c > @@ -228,6 +228,11 @@ static

[U-Boot] [PATCH] part_dos: fix crash with big sector size

2011-06-03 Thread Sergei Shtylyov
Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it tries to read the MBR into 512-byte buffer situated on stack. Instead use the variable length arrays to be safe with any large sector size. Signed-off-by: Sergei Shtylyov --- The same change is probably needed for

Re: [U-Boot] [PATCH 6/8] Adds wait to atmel_usart serial_init function

2011-07-01 Thread Sergei Shtylyov
Hello. On 30-06-2011 23:33, Alex Waterman wrote: > Adds a short busy loop wait to the atmel_usart.c serial_init() > function. > Signed-off-by: Alex Waterman > diff --git a/drivers/serial/atmel_usart.c b/drivers/serial/atmel_usart.c > index e326b2b..e355706 100644 > --- a/drivers/serial/atmel_us

Re: [U-Boot] [PATCH] part_dos: fix crash with big sector size

2011-07-04 Thread Sergei Shtylyov
Hello. I wrote: > Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it > tries to read the MBR into 512-byte buffer situated on stack. Instead use the > variable length arrays to be safe with any large sector size. > Signed-off-by: Sergei Shtylyov Wo

Re: [U-Boot] [PATCH 5/5] USB: Set portnr so USB1.1 and 1.0 devices work on EHCI controllers

2011-07-12 Thread Sergei Shtylyov
Hello. Marek Vasut wrote: > Signed-off-by: Marek Vasut Hm... but EHCI controllers only support high speed (USB 2.0) devices... You need a companion controller (UHCI/OHCI) to support the full/low speed devices. WBR, Sergei ___ U-Boot mailing list

  1   2   >